LayoutTests/storage/storageinfo-missing-arguments.html - Issue 24203002: Improve generated "Not enough arguments." TypeError exceptions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/storage/storageinfo-missing-arguments.html

Issue 24203002: Improve generated "Not enough arguments." TypeError exceptions. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: NeedsRebaseline Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/storage/indexeddb/transaction-storeNames-required-expected.txt ('k') | LayoutTests/storage/storageinfo-missing-arguments-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/storage/storageinfo-missing-arguments.html

diff --git a/LayoutTests/storage/storageinfo-missing-arguments.html b/LayoutTests/storage/storageinfo-missing-arguments.html

index f0c9470f6a2eecb0dc12980df47f0c36af190a24..eb2e9583e805e6a9c7a2323b4f2b775c992db8de 100644

--- a/LayoutTests/storage/storageinfo-missing-arguments.html

+++ b/LayoutTests/storage/storageinfo-missing-arguments.html

@@ -5,10 +5,9 @@

description('Ensures that we get exceptions when we do not include required arguments for webkitStorageInfo methods.');

if (window.webkitStorageInfo) {

- var notEnoughArguments = '"TypeError: Not enough arguments"';

- shouldThrow('webkitStorageInfo.requestQuota()', notEnoughArguments);

- shouldThrow('webkitStorageInfo.requestQuota(webkitStorageInfo.TEMPORARY)', notEnoughArguments);

- shouldThrow('webkitStorageInfo.queryUsageAndQuota()', notEnoughArguments);

+ shouldThrow('webkitStorageInfo.requestQuota()', '"TypeError: Failed to execute \'requestQuota\' on \'StorageInfo\': 2 arguments required, but only 0 present."');

+ shouldThrow('webkitStorageInfo.requestQuota(webkitStorageInfo.TEMPORARY)', '"TypeError: Failed to execute \'requestQuota\' on \'StorageInfo\': 2 arguments required, but only 1 present."');

+ shouldThrow('webkitStorageInfo.queryUsageAndQuota()', '"TypeError: Failed to execute \'queryUsageAndQuota\' on \'StorageInfo\': 1 argument required, but only 0 present."');

} else

debug("This test requires window.webkitStorageInfo.");