Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Unified Diff: LayoutTests/fast/dom/text-api-arguments.html

Issue 24203002: Improve generated "Not enough arguments." TypeError exceptions. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: NeedsRebaseline Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fast/dom/text-api-arguments.html
diff --git a/LayoutTests/fast/dom/text-api-arguments.html b/LayoutTests/fast/dom/text-api-arguments.html
index d3b7e4b3e2318c12fc155781f050572ed4711f8c..af86974edd441eeca4427e082ce121d934d9b2d7 100644
--- a/LayoutTests/fast/dom/text-api-arguments.html
+++ b/LayoutTests/fast/dom/text-api-arguments.html
@@ -15,7 +15,7 @@ shouldBe("text.__proto__", "Text.prototype");
// Text splitText(unsigned long offset)
shouldBeEqualToString("text.splitText(4).data", "efg");
shouldBeEqualToString("text.data", "abcd");
-shouldThrow("text.splitText()", "'TypeError: Not enough arguments'");
+shouldThrow("text.splitText()", '"TypeError: Failed to execute \'splitText\' on \'Text\': 1 argument required, but only 0 present."');
shouldBeEqualToString("text.data", "abcd");
shouldThrow("text.splitText(999)", '"IndexSizeError: Failed to execute \'splitText\' on \'Text\': The offset 999 is larger than the Text node\'s length."'); // offset greater than length
shouldBeEqualToString("text.data", "abcd");
@@ -30,7 +30,7 @@ shouldBe("text.replaceWholeText('test')", "text");
shouldBeEqualToString("text.data", "test");
shouldBeNull("text.replaceWholeText('')");
shouldBeEqualToString("text.data", "test");
-shouldThrow("text.replaceWholeText()", "'TypeError: Not enough arguments'");
+shouldThrow("text.replaceWholeText()", '"TypeError: Failed to execute \'replaceWholeText\' on \'Text\': 1 argument required, but only 0 present."');
shouldBeEqualToString("text.data", "test");
shouldBe("text.replaceWholeText(null)", "text");
shouldBeEqualToString("text.data", "null");
« no previous file with comments | « LayoutTests/fast/dom/shadow/css-hostrule-api-expected.txt ('k') | LayoutTests/fast/dom/text-api-arguments-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698