LayoutTests/fast/canvas/script-tests/canvas-overloads-drawImageFromRect.js - Issue 24203002: Improve generated "Not enough arguments." TypeError exceptions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/canvas/script-tests/canvas-overloads-drawImageFromRect.js

Issue 24203002: Improve generated "Not enough arguments." TypeError exceptions. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: NeedsRebaseline Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/canvas/script-tests/canvas-overloads-drawImage.js ('k') | LayoutTests/fast/canvas/script-tests/canvas-overloads-fillText.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/canvas/script-tests/canvas-overloads-drawImageFromRect.js

diff --git a/LayoutTests/fast/canvas/script-tests/canvas-overloads-drawImageFromRect.js b/LayoutTests/fast/canvas/script-tests/canvas-overloads-drawImageFromRect.js

index 6a5c0a865c790598a712053141e20a97e4135b41..0f40f310d825bfe814e2635da555dbf2ef0b7776 100644

--- a/LayoutTests/fast/canvas/script-tests/canvas-overloads-drawImageFromRect.js

+++ b/LayoutTests/fast/canvas/script-tests/canvas-overloads-drawImageFromRect.js

@@ -2,10 +2,12 @@ description("Test the behavior of CanvasRenderingContext2D.drawImageFromRect() w

var ctx = document.createElement('canvas').getContext('2d');

-var NotEnoughArguments = "TypeError: Not enough arguments";

+function ExpectedNotEnoughArgumentsMessage(num) {

+ return "\"TypeError: Failed to execute 'drawImageFromRect' on 'CanvasRenderingContext2D': 1 argument required, but only " + num + " present.\"";

var imageElement = document.createElement("img");

-shouldThrow("ctx.drawImageFromRect()", "NotEnoughArguments");

+shouldThrow("ctx.drawImageFromRect()", ExpectedNotEnoughArgumentsMessage(0));

shouldBe("ctx.drawImageFromRect(imageElement)", "undefined");

shouldBe("ctx.drawImageFromRect(imageElement, 0)", "undefined");

shouldBe("ctx.drawImageFromRect(imageElement, 0, 0)", "undefined");