Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: LayoutTests/fast/canvas/drawImage-with-valid-image.html

Issue 24203002: Improve generated "Not enough arguments." TypeError exceptions. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: NeedsRebaseline Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fast/canvas/drawImage-with-valid-image.html
diff --git a/LayoutTests/fast/canvas/drawImage-with-valid-image.html b/LayoutTests/fast/canvas/drawImage-with-valid-image.html
index 5e870be1ddb9f02c81bf552b695a408bb3928a63..541f4c24e8e68a8441ae402d4f4d3dc6bfb7ecae 100644
--- a/LayoutTests/fast/canvas/drawImage-with-valid-image.html
+++ b/LayoutTests/fast/canvas/drawImage-with-valid-image.html
@@ -7,7 +7,9 @@
window.jsTestIsAsync = true;
description("This test checks behavior of valid arguments to Canvas::drawImage that use a valid source image.");
- var TypeError = "TypeError: Not enough arguments";
+ function ExpectedNotEnoughArgumentsMessage(num) {
+ return "\"TypeError: Failed to execute 'drawImage' on 'CanvasRenderingContext2D': 3 arguments required, but only " + num + " present.\"";
+ }
var IndexSizeError = "IndexSizeError: Index or size was negative, or greater than the allowed value.";
// Create image
@@ -20,13 +22,13 @@
var ctx = document.createElement("canvas").getContext('2d');
function draw() {
// No arguments should get exception
- shouldThrow("ctx.drawImage()", "TypeError");
+ shouldThrow("ctx.drawImage()", ExpectedNotEnoughArgumentsMessage(0));
// image argument only should get exception
- shouldThrow("ctx.drawImage(myImage)", "TypeError");
+ shouldThrow("ctx.drawImage(myImage)", ExpectedNotEnoughArgumentsMessage(1));
// image argument plus one number should get exception
- shouldThrow("ctx.drawImage(myImage, 0)", "TypeError");
+ shouldThrow("ctx.drawImage(myImage, 0)", ExpectedNotEnoughArgumentsMessage(2));
// image argument plus 2 numbers
shouldNotThrow("ctx.drawImage(myImage, 0, 0)");
@@ -151,4 +153,4 @@
</script>
<script src="../js/resources/js-test-post.js"></script>
</body>
-</html>
+</html>

Powered by Google App Engine
This is Rietveld 408576698