Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Side by Side Diff: LayoutTests/fast/canvas/script-tests/canvas-overloads-setFillColor.js

Issue 24203002: Improve generated "Not enough arguments." TypeError exceptions. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: NeedsRebaseline Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 description("Test the behavior of CanvasRenderingContext2D.setFillColor() when c alled with different numbers of arguments."); 1 description("Test the behavior of CanvasRenderingContext2D.setFillColor() when c alled with different numbers of arguments.");
2 2
3 var ctx = document.createElement('canvas').getContext('2d'); 3 var ctx = document.createElement('canvas').getContext('2d');
4 4
5 function ExpectedNotEnoughArgumentsMessage(num) {
6 return "\"TypeError: Failed to execute 'setFillColor' on 'CanvasRenderingCon text2D': 1 argument required, but only " + num + " present.\"";
7 }
8
5 var TypeError = "TypeError: Type error"; 9 var TypeError = "TypeError: Type error";
6 var TypeErrorNotEnoughArguments = "TypeError: Not enough arguments";
7 10
8 shouldThrow("ctx.setFillColor()", "TypeErrorNotEnoughArguments"); 11 shouldThrow("ctx.setFillColor()", ExpectedNotEnoughArgumentsMessage(0));
9 shouldBe("ctx.setFillColor('red')", "undefined"); 12 shouldBe("ctx.setFillColor('red')", "undefined");
10 shouldBe("ctx.setFillColor(0)", "undefined"); 13 shouldBe("ctx.setFillColor(0)", "undefined");
11 shouldBe("ctx.setFillColor(0, 0)", "undefined"); 14 shouldBe("ctx.setFillColor(0, 0)", "undefined");
12 shouldThrow("ctx.setFillColor(0, 0, 0)", "TypeError"); 15 shouldThrow("ctx.setFillColor(0, 0, 0)", "TypeError");
13 shouldBe("ctx.setFillColor(0, 0, 0, 0)", "undefined"); 16 shouldBe("ctx.setFillColor(0, 0, 0, 0)", "undefined");
14 shouldBe("ctx.setFillColor(0, 0, 0, 0, 0)", "undefined"); 17 shouldBe("ctx.setFillColor(0, 0, 0, 0, 0)", "undefined");
15 shouldThrow("ctx.setFillColor(0, 0, 0, 0, 0, 0)", "TypeError"); 18 shouldThrow("ctx.setFillColor(0, 0, 0, 0, 0, 0)", "TypeError");
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698