Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2420233002:
Bump Chrome's deployment target to macOS 10.8. (Closed)
DescriptionBump Chrome's deployment target to macOS 10.8.
I also updated the comment to better reflect the relationship between Chrome and
its dependencies. Several Chrome dependencies require a different min sdk and/or
deployment target from Chrome.
BUG=622481
Committed: https://crrev.com/3dade40fe88881864a42134f92238a6d292d8505
Committed: https://crrev.com/45fd5f3efc52919eea92025f2ae95ba244bff176
Cr-Original-Commit-Position: refs/heads/master@{#425870}
Cr-Commit-Position: refs/heads/master@{#426822}
Patch Set 1 #Patch Set 2 : nits #
Depends on Patchset: Messages
Total messages: 25 (11 generated)
erikchen@chromium.org changed reviewers: + thakis@chromium.org
thakis: Please review if you're around. Otherwise I'll find someone else.
The CQ bit was checked by erikchen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/10/14 21:55:23, erikchen wrote: > thakis: Please review if you're around. Otherwise I'll find someone else. There's still an open blocker, how does this build?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2016/10/14 22:11:20, Nico (mostly afk until Oct 23) wrote: > On 2016/10/14 21:55:23, erikchen wrote: > > thakis: Please review if you're around. Otherwise I'll find someone else. > > There's still an open blocker, how does this build? see the dependent CL.
On 2016/10/15 00:41:34, erikchen wrote: > On 2016/10/14 22:11:20, Nico (mostly afk until Oct 23) wrote: > > On 2016/10/14 21:55:23, erikchen wrote: > > > thakis: Please review if you're around. Otherwise I'll find someone else. > > > > There's still an open blocker, how does this build? > > see the dependent CL. Aha, thanks, sorry for missing this. Very lgtm, I'm super excited about this happening :-)
The CQ bit was checked by erikchen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Bump Chrome's deployment target to macOS 10.8. I also updated the comment to better reflect the relationship between Chrome and its dependencies. Several Chrome dependencies require a different min sdk and/or deployment target from Chrome. BUG=622481 ========== to ========== Bump Chrome's deployment target to macOS 10.8. I also updated the comment to better reflect the relationship between Chrome and its dependencies. Several Chrome dependencies require a different min sdk and/or deployment target from Chrome. BUG=622481 Committed: https://crrev.com/3dade40fe88881864a42134f92238a6d292d8505 Cr-Commit-Position: refs/heads/master@{#425870} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/3dade40fe88881864a42134f92238a6d292d8505 Cr-Commit-Position: refs/heads/master@{#425870}
Message was sent while issue was closed.
\o/ On Oct 17, 2016 10:47 PM, "commit-bot@chromium.org via codereview.chromium.org" <reply@chromiumcodereview-hr.appspotmail.com> wrote: > Committed patchset #2 (id:20001) > > https://codereview.chromium.org/2420233002/ > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2426673003/ by tzik@chromium.org. The reason for reverting is: This CL seems to break a number of layout tests on Mac bots. Most of them probably just needs an expectation update. The error logs are available here: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.9/builds... https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Mac10_9/3... .
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2423373002/ by guidou@chromium.org. The reason for reverting is: Speculative revert. WebKit Mac Retina 10.10 bot broke and this is the only mac-specific CL in the blamelist. If the revert does not work, I will reland. https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28....
Message was sent while issue was closed.
Description was changed from ========== Bump Chrome's deployment target to macOS 10.8. I also updated the comment to better reflect the relationship between Chrome and its dependencies. Several Chrome dependencies require a different min sdk and/or deployment target from Chrome. BUG=622481 Committed: https://crrev.com/3dade40fe88881864a42134f92238a6d292d8505 Cr-Commit-Position: refs/heads/master@{#425870} ========== to ========== Bump Chrome's deployment target to macOS 10.8. I also updated the comment to better reflect the relationship between Chrome and its dependencies. Several Chrome dependencies require a different min sdk and/or deployment target from Chrome. BUG=622481 Committed: https://crrev.com/3dade40fe88881864a42134f92238a6d292d8505 Cr-Commit-Position: refs/heads/master@{#425870} ==========
On 2016/10/18 08:59:56, Guido Urdaneta wrote: > A revert of this CL (patchset #2 id:20001) has been created in > https://codereview.chromium.org/2423373002/ by mailto:guidou@chromium.org. > > The reason for reverting is: Speculative revert. > WebKit Mac Retina 10.10 bot broke and this is the only mac-specific CL in the > blamelist. > If the revert does not work, I will reland. > > https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28.... Relanding this. Layout test failures have been fixed here: https://codereview.chromium.org/2438843003/
The CQ bit was checked by erikchen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Bump Chrome's deployment target to macOS 10.8. I also updated the comment to better reflect the relationship between Chrome and its dependencies. Several Chrome dependencies require a different min sdk and/or deployment target from Chrome. BUG=622481 Committed: https://crrev.com/3dade40fe88881864a42134f92238a6d292d8505 Cr-Commit-Position: refs/heads/master@{#425870} ========== to ========== Bump Chrome's deployment target to macOS 10.8. I also updated the comment to better reflect the relationship between Chrome and its dependencies. Several Chrome dependencies require a different min sdk and/or deployment target from Chrome. BUG=622481 Committed: https://crrev.com/3dade40fe88881864a42134f92238a6d292d8505 Cr-Commit-Position: refs/heads/master@{#425870} ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Bump Chrome's deployment target to macOS 10.8. I also updated the comment to better reflect the relationship between Chrome and its dependencies. Several Chrome dependencies require a different min sdk and/or deployment target from Chrome. BUG=622481 Committed: https://crrev.com/3dade40fe88881864a42134f92238a6d292d8505 Cr-Commit-Position: refs/heads/master@{#425870} ========== to ========== Bump Chrome's deployment target to macOS 10.8. I also updated the comment to better reflect the relationship between Chrome and its dependencies. Several Chrome dependencies require a different min sdk and/or deployment target from Chrome. BUG=622481 Committed: https://crrev.com/3dade40fe88881864a42134f92238a6d292d8505 Committed: https://crrev.com/45fd5f3efc52919eea92025f2ae95ba244bff176 Cr-Original-Commit-Position: refs/heads/master@{#425870} Cr-Commit-Position: refs/heads/master@{#426822} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/45fd5f3efc52919eea92025f2ae95ba244bff176 Cr-Commit-Position: refs/heads/master@{#426822} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
