Flash: Use better APIs for preventing sleep

Flash: Use better APIs for preventing sleep

The API that this was using on Mac has been deprecated, and is
preventing us from upgrading our SDK version. We have a cross-platform
sleep-preventation API. Use that instead.

The Flash API for preventing power is a bit idiosyncratic in that it
doesn't create and destroy power blockers, but rather says "please don't
go to sleep for a while", where "a while" is not defined. Empirically,
twitch.tv called this method every 10 seconds. Use a timeout of 45
seconds to be safe.

BUG=650797
Committed: https://crrev.com/04c2bac53d96749f85f9046d9923810df58d41c1
Cr-Commit-Position: refs/heads/master@{#425843}

[ccameron, 2016-10-04 19:32:19]

Description was changed from

==========
Flash: Use better APIs for preventing sleep

The API that this was using on Mac has been deprecated. We have a
cross-platform sleep-preventation API. Use that instead.

The Flash API for preventing power is a bit idiosyncratic in that it
doesn't create and destroy power blockers, but rather says "please don't
go to sleep for a while", where "a while" is not defined. Empirically,
twitch.tv called this method every 10 seconds. Use a timeout of 45
seconds to be safe.

BUG=650797
==========

to

==========
Flash: Use better APIs for preventing sleep

The API that this was using on Mac has been deprecated, and is
preventing us from upgrading our SDK version. We have a cross-platform
sleep-preventation API. Use that instead.

The Flash API for preventing power is a bit idiosyncratic in that it
doesn't create and destroy power blockers, but rather says "please don't
go to sleep for a while", where "a while" is not defined. Empirically,
twitch.tv called this method every 10 seconds. Use a timeout of 45
seconds to be safe.

BUG=650797
==========

[ccameron, 2016-10-04 19:32:19]

ccameron@chromium.org changed reviewers:
+ scottmg@chromium.org

[ccameron, 2016-10-04 19:32:24]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[ccameron, 2016-10-04 19:33:13]

ptal

[commit-bot: I haz the power, 2016-10-04 19:33:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[scottmg, 2016-10-04 19:42:36]

non-owner lgtm

[ccameron, 2016-10-04 19:43:43]

Adding bbudge for pepper OWNER

[commit-bot: I haz the power, 2016-10-04 21:53:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 21:53:46]

Dry run: This issue passed the CQ dry run.

[erikchen, 2016-10-12 23:14:55]

erikchen@chromium.org changed reviewers:
+ bbudge@chromium.org, erikchen@chromium.org

[erikchen, 2016-10-12 23:14:56]

Actually adding bbudge this time.

[bbudge, 2016-10-13 19:53:51]

https://codereview.chromium.org/2388313004/diff/1/chrome/browser/renderer_hos...
File chrome/browser/renderer_host/pepper/pepper_flash_browser_host.cc (right):

https://codereview.chromium.org/2388313004/diff/1/chrome/browser/renderer_hos...
chrome/browser/renderer_host/pepper/pepper_flash_browser_host.cc:97:
base::TimeDelta::FromSeconds(45));
Since this is a plugin API, it seems bad to allow the plugin to create an
unlimited number of PowerSaveBlocker instances.

Could you instead hold a reference to the PowerSaveBlocker on this host class,
and post tasks to reset that reference? You'd have to check in UpdateActivity
for a pending task and kill that before launching another.

[ccameron, 2016-10-14 21:39:43]

Updated ptal.

https://codereview.chromium.org/2388313004/diff/1/chrome/browser/renderer_hos...
File chrome/browser/renderer_host/pepper/pepper_flash_browser_host.cc (right):

https://codereview.chromium.org/2388313004/diff/1/chrome/browser/renderer_hos...
chrome/browser/renderer_host/pepper/pepper_flash_browser_host.cc:97:
base::TimeDelta::FromSeconds(45));
On 2016/10/13 19:53:51, bbudge wrote:
> Since this is a plugin API, it seems bad to allow the plugin to create an
> unlimited number of PowerSaveBlocker instances.
> 
> Could you instead hold a reference to the PowerSaveBlocker on this host class,
> and post tasks to reset that reference? You'd have to check in UpdateActivity
> for a pending task and kill that before launching another.

Sure -- switched it to a DelayTimer impl.

[bbudge, 2016-10-14 22:39:37]

lgtm Thank you!

[erikchen, 2016-10-17 17:08:16]

The CQ bit was checked by erikchen@chromium.org

[erikchen, 2016-10-17 17:08:17]

The patchset sent to the CQ was uploaded after l-g-t-m from scottmg@chromium.org
Link to the patchset: https://codereview.chromium.org/2388313004/#ps20001
(title: "Use DelayTimer")

[commit-bot: I haz the power, 2016-10-17 17:08:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-17 17:17:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-17 17:17:34]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[erikchen, 2016-10-17 23:48:20]

erikchen@chromium.org changed reviewers:
+ thakis@chromium.org

[erikchen, 2016-10-17 23:48:21]

+thakis for OWNER review of chrome.

[Nico, 2016-10-17 23:55:52]

rs-lgtm

[erikchen, 2016-10-18 00:11:11]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2016-10-18 00:12:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-18 01:06:48]

Description was changed from

==========
Flash: Use better APIs for preventing sleep

The API that this was using on Mac has been deprecated, and is
preventing us from upgrading our SDK version. We have a cross-platform
sleep-preventation API. Use that instead.

The Flash API for preventing power is a bit idiosyncratic in that it
doesn't create and destroy power blockers, but rather says "please don't
go to sleep for a while", where "a while" is not defined. Empirically,
twitch.tv called this method every 10 seconds. Use a timeout of 45
seconds to be safe.

BUG=650797
==========

to

==========
Flash: Use better APIs for preventing sleep

The API that this was using on Mac has been deprecated, and is
preventing us from upgrading our SDK version. We have a cross-platform
sleep-preventation API. Use that instead.

The Flash API for preventing power is a bit idiosyncratic in that it
doesn't create and destroy power blockers, but rather says "please don't
go to sleep for a while", where "a while" is not defined. Empirically,
twitch.tv called this method every 10 seconds. Use a timeout of 45
seconds to be safe.

BUG=650797
==========

[commit-bot: I haz the power, 2016-10-18 01:06:52]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-18 01:10:33]

Description was changed from

==========
Flash: Use better APIs for preventing sleep

The API that this was using on Mac has been deprecated, and is
preventing us from upgrading our SDK version. We have a cross-platform
sleep-preventation API. Use that instead.

The Flash API for preventing power is a bit idiosyncratic in that it
doesn't create and destroy power blockers, but rather says "please don't
go to sleep for a while", where "a while" is not defined. Empirically,
twitch.tv called this method every 10 seconds. Use a timeout of 45
seconds to be safe.

BUG=650797
==========

to

==========
Flash: Use better APIs for preventing sleep

The API that this was using on Mac has been deprecated, and is
preventing us from upgrading our SDK version. We have a cross-platform
sleep-preventation API. Use that instead.

The Flash API for preventing power is a bit idiosyncratic in that it
doesn't create and destroy power blockers, but rather says "please don't
go to sleep for a while", where "a while" is not defined. Empirically,
twitch.tv called this method every 10 seconds. Use a timeout of 45
seconds to be safe.

BUG=650797

Committed: https://crrev.com/04c2bac53d96749f85f9046d9923810df58d41c1
Cr-Commit-Position: refs/heads/master@{#425843}
==========

[commit-bot: I haz the power, 2016-10-18 01:10:34]

Patchset 2 (id:??) landed as
https://crrev.com/04c2bac53d96749f85f9046d9923810df58d41c1
Cr-Commit-Position: refs/heads/master@{#425843}