Issue 24201005: Refactoring: Move queryLocalizedString() to Locale class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 24201005: Refactoring: Move queryLocalizedString() to Locale class. (Closed)

Created:
7 years, 3 months ago by tkent

Modified:
7 years, 3 months ago

Reviewers:
keishi

CC:
blink-reviews, dglazkov+blink, jeez, adamk+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Refactoring: Move queryLocalizedString() to Locale class. They always return strings for browser UI locale for now. We'd like to update them so that they return locale-dependent strings in the future. Also, remove unused functions of LocalizedStrings. BUG=161733 TEST=none; no behavior changes. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158004

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+51 lines, -54 lines)			Patch
M	Source/core/html/EmailInputType.cpp	View	2 chunks	+10 lines, -10 lines	0 comments	Download
M	Source/core/html/InputType.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/html/InputType.cpp	View	3 chunks	+9 lines, -3 lines	0 comments	Download
M	Source/core/platform/LocalizedStrings.h	View	2 chunks	+1 line, -8 lines	0 comments	Download
M	Source/core/platform/LocalizedStrings.cpp	View	3 chunks	+3 lines, -33 lines	0 comments	Download
M	Source/core/platform/text/PlatformLocale.h	View	2 chunks	+5 lines, -0 lines	0 comments	Download
M	Source/core/platform/text/PlatformLocale.cpp	View	2 chunks	+22 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/24201005/1

7 years, 3 months ago (2013-09-19 05:04:05 UTC) #3

Message was sent while issue was closed.

Change committed as 158004

Expand Messages | Collapse Messages