Issue 24197002: Don't send the oncompleted signal twice in the webnavigation API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 24197002: Don't send the oncompleted signal twice in the webnavigation API (Closed)

Created:
7 years, 3 months ago by jochen (gone - plz use gerrit)

Modified:
7 years, 3 months ago

Reviewers:
marja

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Don't send the oncompleted signal twice in the webnavigation API We shouldn't preemptivly mark a navigation as completed if it's a history or reference fragment navigation, as such a navigation might happen in parallel to an ongoing navigation BUG=279483 R=marja@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223596

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+52 lines, -4 lines)			Patch
M	chrome/browser/extensions/api/web_navigation/web_navigation_api.cc	View	1 chunk	+0 lines, -3 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/webnavigation/history/c.html	View	1 chunk	+1 line, -0 lines	0 comments	Download
A +	chrome/test/data/extensions/api_test/webnavigation/history/c.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/data/extensions/api_test/webnavigation/test_history.js	View	1 chunk	+50 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/24197002/1

7 years, 3 months ago (2013-09-17 10:38:07 UTC) #3

Message was sent while issue was closed.

Change committed as 223596