Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4875)

Unified Diff: chrome/browser/extensions/api/web_navigation/web_navigation_api.cc

Issue 24197002: Don't send the oncompleted signal twice in the webnavigation API (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/test/data/extensions/api_test/webnavigation/history/c.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/web_navigation/web_navigation_api.cc
diff --git a/chrome/browser/extensions/api/web_navigation/web_navigation_api.cc b/chrome/browser/extensions/api/web_navigation/web_navigation_api.cc
index ed2e61c379b0d4350b6c526bbbb1c70140dd51ee..cdf05541e03328a2088f3a166dece1d3821fa5c9 100644
--- a/chrome/browser/extensions/api/web_navigation/web_navigation_api.cc
+++ b/chrome/browser/extensions/api/web_navigation/web_navigation_api.cc
@@ -447,9 +447,6 @@ void WebNavigationTabObserver::DidCommitProvisionalLoadForFrame(
navigation_state_.UpdateFrame(frame_id, url);
navigation_state_.SetNavigationCommitted(frame_id);
- if (is_reference_fragment_navigation || is_history_state_modification)
- navigation_state_.SetNavigationCompleted(frame_id);
-
if (!navigation_state_.CanSendEvents(frame_id))
return;
« no previous file with comments | « no previous file | chrome/test/data/extensions/api_test/webnavigation/history/c.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698