Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2418303002: Use TracedValue in runtime statistics. (Closed)

Created:
4 years, 2 months ago by lpy
Modified:
4 years, 1 month ago
Reviewers:
fmeawad, Camillo Bruni
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Use TracedValue in runtime statistics. We introduced TracedValue into V8 tracing previously, this patch uses it to build JSON string of runtime statistics instead of using stringstream as buffer. BUG=v8:5089 LOG=N Committed: https://crrev.com/65b3af466e9aea7bc451558d671fcd9866b6cbe3 Cr-Commit-Position: refs/heads/master@{#40443}

Patch Set 1 #

Total comments: 2

Patch Set 2 : address cbruni's comments #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -21 lines) Patch
M src/counters.h View 1 2 4 chunks +3 lines, -3 lines 0 comments Download
M src/counters.cc View 1 2 2 chunks +12 lines, -14 lines 0 comments Download
M src/tracing/trace-event.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/tracing/traced-value.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/tracing/traced-value.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 25 (18 generated)
lpy
PTAL.
4 years, 2 months ago (2016-10-14 22:40:12 UTC) #4
Camillo Bruni
lgtm with nit https://codereview.chromium.org/2418303002/diff/1/src/counters.cc File src/counters.cc (right): https://codereview.chromium.org/2418303002/diff/1/src/counters.cc#newcode369 src/counters.cc:369: } Please leave the separate function ...
4 years, 2 months ago (2016-10-18 07:52:24 UTC) #7
lpy
thanks, ptal. https://codereview.chromium.org/2418303002/diff/1/src/counters.cc File src/counters.cc (right): https://codereview.chromium.org/2418303002/diff/1/src/counters.cc#newcode369 src/counters.cc:369: } On 2016/10/18 07:52:24, Camillo Bruni wrote: ...
4 years, 2 months ago (2016-10-18 19:43:45 UTC) #17
Camillo Bruni
thanks, lgtm again.
4 years, 2 months ago (2016-10-19 11:30:56 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2418303002/60001
4 years, 2 months ago (2016-10-19 14:52:05 UTC) #22
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 2 months ago (2016-10-19 14:56:24 UTC) #23
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:06:53 UTC) #25
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/65b3af466e9aea7bc451558d671fcd9866b6cbe3
Cr-Commit-Position: refs/heads/master@{#40443}

Powered by Google App Engine
This is Rietveld 408576698