Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Unified Diff: src/counters.h

Issue 2418303002: Use TracedValue in runtime statistics. (Closed)
Patch Set: rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/counters.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/counters.h
diff --git a/src/counters.h b/src/counters.h
index 8967c500c54b0932f9532b7c11be6aed0de8338f..c4a20dc30c213c18be674a1f05066d7dab520e12 100644
--- a/src/counters.h
+++ b/src/counters.h
@@ -15,6 +15,7 @@
#include "src/objects.h"
#include "src/runtime/runtime.h"
#include "src/tracing/trace-event.h"
+#include "src/tracing/traced-value.h"
namespace v8 {
namespace internal {
@@ -484,7 +485,7 @@ double AggregatedMemoryHistogram<Histogram>::Aggregate(double current_ms,
struct RuntimeCallCounter {
explicit RuntimeCallCounter(const char* name) : name(name) {}
V8_NOINLINE void Reset();
- V8_NOINLINE void Dump(std::stringstream& out);
+ V8_NOINLINE void Dump(v8::tracing::TracedValue* value);
const char* name;
int64_t count = 0;
@@ -799,7 +800,7 @@ class RuntimeCallStats {
void Reset();
void Print(std::ostream& os);
- std::string Dump();
+ V8_NOINLINE void Dump(v8::tracing::TracedValue* value);
RuntimeCallStats() {
Reset();
@@ -810,7 +811,6 @@ class RuntimeCallStats {
bool InUse() { return in_use_; }
private:
- std::stringstream buffer_;
// Counter to track recursive time events.
RuntimeCallTimer* current_timer_ = NULL;
// Used to track nested tracing scopes.
« no previous file with comments | « no previous file | src/counters.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698