third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h - Issue 2417303002: Refactor PLSA scrollbar existence calculation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h

Issue 2417303002: Refactor PLSA scrollbar existence calculation. (Closed)

Patch Set: Sync + rebaseline invalidation tests. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h

diff --git a/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h b/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h

index 3dbebffcc004b8b14126ffbf7d94bd82c6775ae7..38a974378f6b2f6a371837748ee07b4318ceca84 100644

--- a/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h

+++ b/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h

@@ -510,6 +510,12 @@ class CORE_EXPORT PaintLayerScrollableArea final

int horizontalScrollbarStart(int minX) const;

IntSize scrollbarOffset(const Scrollbar&) const;

+ enum ComputeScrollbarExistenceOption { Default, ForbidAddingAutoBars };

+ void computeScrollbarExistence(

+ bool& needsHorizontalScrollbar,

+ bool& needsVerticalScrollbar,

+ ComputeScrollbarExistenceOption = Default) const;

void setHasHorizontalScrollbar(bool hasScrollbar);

void setHasVerticalScrollbar(bool hasScrollbar);