Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h

Issue 2417303002: Refactor PLSA scrollbar existence calculation. (Closed)
Patch Set: Sync + rebaseline invalidation tests. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2003, 2009, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2003, 2009, 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 4 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
5 * 5 *
6 * Other contributors: 6 * Other contributors:
7 * Robert O'Callahan <roc+@cs.cmu.edu> 7 * Robert O'Callahan <roc+@cs.cmu.edu>
8 * David Baron <dbaron@fas.harvard.edu> 8 * David Baron <dbaron@fas.harvard.edu>
9 * Christian Biesinger <cbiesinger@web.de> 9 * Christian Biesinger <cbiesinger@web.de>
10 * Randall Jesup <rjesup@wgate.com> 10 * Randall Jesup <rjesup@wgate.com>
(...skipping 492 matching lines...) Expand 10 before | Expand all | Expand 10 after
503 503
504 void updateScrollOrigin(); 504 void updateScrollOrigin();
505 void updateScrollDimensions(); 505 void updateScrollDimensions();
506 506
507 void updateScrollOffset(const ScrollOffset&, ScrollType) override; 507 void updateScrollOffset(const ScrollOffset&, ScrollType) override;
508 508
509 int verticalScrollbarStart(int minX, int maxX) const; 509 int verticalScrollbarStart(int minX, int maxX) const;
510 int horizontalScrollbarStart(int minX) const; 510 int horizontalScrollbarStart(int minX) const;
511 IntSize scrollbarOffset(const Scrollbar&) const; 511 IntSize scrollbarOffset(const Scrollbar&) const;
512 512
513 enum ComputeScrollbarExistenceOption { Default, ForbidAddingAutoBars };
514 void computeScrollbarExistence(
515 bool& needsHorizontalScrollbar,
516 bool& needsVerticalScrollbar,
517 ComputeScrollbarExistenceOption = Default) const;
518
513 void setHasHorizontalScrollbar(bool hasScrollbar); 519 void setHasHorizontalScrollbar(bool hasScrollbar);
514 void setHasVerticalScrollbar(bool hasScrollbar); 520 void setHasVerticalScrollbar(bool hasScrollbar);
515 521
516 void updateScrollCornerStyle(); 522 void updateScrollCornerStyle();
517 523
518 // See comments on isPointInResizeControl. 524 // See comments on isPointInResizeControl.
519 void updateResizerAreaSet(); 525 void updateResizerAreaSet();
520 void updateResizerStyle(); 526 void updateResizerStyle();
521 527
522 void updateScrollableAreaSet(bool hasOverflow); 528 void updateScrollableAreaSet(bool hasOverflow);
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
589 595
590 DEFINE_TYPE_CASTS(PaintLayerScrollableArea, 596 DEFINE_TYPE_CASTS(PaintLayerScrollableArea,
591 ScrollableArea, 597 ScrollableArea,
592 scrollableArea, 598 scrollableArea,
593 scrollableArea->isPaintLayerScrollableArea(), 599 scrollableArea->isPaintLayerScrollableArea(),
594 scrollableArea.isPaintLayerScrollableArea()); 600 scrollableArea.isPaintLayerScrollableArea());
595 601
596 } // namespace blink 602 } // namespace blink
597 603
598 #endif // LayerScrollableArea_h 604 #endif // LayerScrollableArea_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698