third_party/WebKit/Source/core/layout/ng/ng_physical_text_fragment.h - Issue 2417113002: [LayoutNG] Fix orthogonal writing mode child margin strut from being used in collapsing margins cal…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_physical_text_fragment.h

Issue 2417113002: [LayoutNG] Fix orthogonal writing mode child margin strut from being used in collapsing margins cal… (Closed)

Patch Set: address comments Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/layout/ng/ng_physical_text_fragment.h

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_physical_text_fragment.h b/third_party/WebKit/Source/core/layout/ng/ng_physical_text_fragment.h

index 5495c46d0f4e0113e515ebde657e2cd233bf9660..23d05c3c27975472da1a56eb84deabb643738919 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_physical_text_fragment.h

+++ b/third_party/WebKit/Source/core/layout/ng/ng_physical_text_fragment.h

@@ -17,7 +17,7 @@ namespace blink {

class CORE_EXPORT NGPhysicalTextFragment final : public NGPhysicalFragmentBase {

public:

NGPhysicalTextFragment(NGPhysicalSize size, NGPhysicalSize overflow)

- : NGPhysicalFragmentBase(size, overflow, FragmentText, {}) {}

+ : NGPhysicalFragmentBase(size, overflow, FragmentText) {}

String Text() const { return text_list_->Text(start_offset_, end_offset_); }

« no previous file with comments | « third_party/WebKit/Source/core/layout/ng/ng_physical_fragment_base.h ('k') | no next file » | no next file with comments »