Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(586)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_physical_fragment_base.h

Issue 2417113002: [LayoutNG] Fix orthogonal writing mode child margin strut from being used in collapsing margins cal… (Closed)
Patch Set: address comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_physical_fragment_base.h
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_physical_fragment_base.h b/third_party/WebKit/Source/core/layout/ng/ng_physical_fragment_base.h
index 0a5000af6c6d7df907ec1c9a2277159f4df624f4..75a22999a6f60aef1ab500f3bbc4ab3947f4b8dc 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_physical_fragment_base.h
+++ b/third_party/WebKit/Source/core/layout/ng/ng_physical_fragment_base.h
@@ -59,26 +59,21 @@ class CORE_EXPORT NGPhysicalFragmentBase
has_been_placed_ = true;
}
- NGMarginStrut MarginStrut() const { return margin_strut_; }
-
DEFINE_INLINE_TRACE_AFTER_DISPATCH() {}
DECLARE_TRACE();
protected:
NGPhysicalFragmentBase(NGPhysicalSize size,
NGPhysicalSize overflow,
- NGFragmentType type,
- NGMarginStrut margin_strut)
+ NGFragmentType type)
: size_(size),
overflow_(overflow),
- margin_strut_(margin_strut),
type_(type),
has_been_placed_(false) {}
NGPhysicalSize size_;
NGPhysicalSize overflow_;
NGPhysicalOffset offset_;
- NGMarginStrut margin_strut_;
unsigned type_ : 1;
unsigned has_been_placed_ : 1;

Powered by Google App Engine
This is Rietveld 408576698