Remove stl_util's deletion functions from:

Remove stl_util's deletion functions from:

- quic_crypto_[client|server]_config (and downstream)
- quic_dispatcher (and downstream)
- simple_quic_framer (and downstream)

Merge internal change: 136758118

BUG=555865
Committed: https://crrev.com/3f0c158f527537e47ecaec41b814fd980d6547f2
Cr-Commit-Position: refs/heads/master@{#426603}

[Avi (use Gerrit), 2016-10-14 00:17:14]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-14 00:17:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-14 00:38:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-14 00:38:24]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Avi (use Gerrit), 2016-10-14 14:36:37]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-14 14:36:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-14 15:49:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-14 15:49:44]

Dry run: This issue passed the CQ dry run.

[Avi (use Gerrit), 2016-10-19 20:23:45]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-19 20:24:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Avi (use Gerrit), 2016-10-19 21:55:47]

Description was changed from

==========
Remove stl_util's deletion functions from:

- quic_crypto_[client|server]_config (and downstream)
- quic_dispatcher (and downstream)
- simple_quic_framer (and downstream)

BUG=555865
==========

to

==========
Remove stl_util's deletion functions from:

- quic_crypto_[client|server]_config (and downstream)
- quic_dispatcher (and downstream)
- simple_quic_framer (and downstream)

Merge internal change: 136646050

BUG=555865
==========

[commit-bot: I haz the power, 2016-10-19 22:46:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-19 22:46:23]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Avi (use Gerrit), 2016-10-20 01:57:47]

avi@chromium.org changed reviewers:
+ zhongyi@chromium.org

[Avi (use Gerrit), 2016-10-20 15:39:30]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 15:39:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 15:45:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-20 15:45:44]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Avi (use Gerrit), 2016-10-20 17:45:39]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 17:46:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 17:57:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-20 17:57:13]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Avi (use Gerrit), 2016-10-20 18:20:20]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 18:21:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Avi (use Gerrit), 2016-10-20 18:37:25]

On 2016/10/20 01:57:47, Avi wrote:

As of patchset 6, this matches the version of the CL that rjshade approved
internally.

[commit-bot: I haz the power, 2016-10-20 18:43:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-20 18:43:02]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Avi (use Gerrit), 2016-10-20 19:01:05]

On 2016/10/20 18:37:25, Avi wrote:
> On 2016/10/20 01:57:47, Avi wrote:
> 
> As of patchset 6, this matches the version of the CL that rjshade approved
> internally.

And it seems to match all the crashes I'm seeing on the internal patch.
Investigating.

[Avi (use Gerrit), 2016-10-20 19:07:40]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 19:08:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Avi (use Gerrit), 2016-10-20 19:36:26]

On 2016/10/20 19:01:05, Avi wrote:
> On 2016/10/20 18:37:25, Avi wrote:
> > On 2016/10/20 01:57:47, Avi wrote:
> > 
> > As of patchset 6, this matches the version of the CL that rjshade approved
> > internally.
> 
> And it seems to match all the crashes I'm seeing on the internal patch.
> Investigating.

This is now fixed; please review.

[commit-bot: I haz the power, 2016-10-20 20:41:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-20 20:41:39]

Dry run: This issue passed the CQ dry run.

[Zhongyi Shi, 2016-10-20 21:08:58]

lgtm

[Avi (use Gerrit), 2016-10-20 21:12:24]

Description was changed from

==========
Remove stl_util's deletion functions from:

- quic_crypto_[client|server]_config (and downstream)
- quic_dispatcher (and downstream)
- simple_quic_framer (and downstream)

Merge internal change: 136646050

BUG=555865
==========

to

==========
Remove stl_util's deletion functions from:

- quic_crypto_[client|server]_config (and downstream)
- quic_dispatcher (and downstream)
- simple_quic_framer (and downstream)

Merge internal change: 136758118

BUG=555865
==========

[Avi (use Gerrit), 2016-10-20 21:12:29]

The CQ bit was checked by avi@chromium.org

[commit-bot: I haz the power, 2016-10-20 21:13:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 21:28:21]

Description was changed from

==========
Remove stl_util's deletion functions from:

- quic_crypto_[client|server]_config (and downstream)
- quic_dispatcher (and downstream)
- simple_quic_framer (and downstream)

Merge internal change: 136758118

BUG=555865
==========

to

==========
Remove stl_util's deletion functions from:

- quic_crypto_[client|server]_config (and downstream)
- quic_dispatcher (and downstream)
- simple_quic_framer (and downstream)

Merge internal change: 136758118

BUG=555865
==========

[commit-bot: I haz the power, 2016-10-20 21:28:22]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-10-21 13:22:49]

Description was changed from

==========
Remove stl_util's deletion functions from:

- quic_crypto_[client|server]_config (and downstream)
- quic_dispatcher (and downstream)
- simple_quic_framer (and downstream)

Merge internal change: 136758118

BUG=555865
==========

to

==========
Remove stl_util's deletion functions from:

- quic_crypto_[client|server]_config (and downstream)
- quic_dispatcher (and downstream)
- simple_quic_framer (and downstream)

Merge internal change: 136758118

BUG=555865

Committed: https://crrev.com/3f0c158f527537e47ecaec41b814fd980d6547f2
Cr-Commit-Position: refs/heads/master@{#426603}
==========

[commit-bot: I haz the power, 2016-10-21 13:22:50]

Patchset 7 (id:??) landed as
https://crrev.com/3f0c158f527537e47ecaec41b814fd980d6547f2
Cr-Commit-Position: refs/heads/master@{#426603}