Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 24127004: Disable child X window workaround when running in test harnesses that do (Closed)

Created:
7 years, 3 months ago by ccameron
Modified:
7 years, 3 months ago
Reviewers:
zmo, Zhenyao Mo
CC:
chromium-reviews
Visibility:
Public.

Description

Disable child X window workaround when running in test harnesses that do not have a message loop. TBR=zmo BUG=145600 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223231

Patch Set 1 #

Patch Set 2 : Clean up comments #

Patch Set 3 : Remove newline #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -12 lines) Patch
M ui/gl/gl_surface_glx.cc View 1 2 6 chunks +28 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ccameron
This should do it
7 years, 3 months ago (2013-09-14 00:13:20 UTC) #1
Zhenyao Mo
On 2013/09/14 00:13:20, ccameron1 wrote: > This should do it LGTM. Thanks for the fix.
7 years, 3 months ago (2013-09-14 00:23:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ccameron@chromium.org/24127004/10001
7 years, 3 months ago (2013-09-14 01:07:58 UTC) #3
commit-bot: I haz the power
7 years, 3 months ago (2013-09-14 05:37:59 UTC) #4
Message was sent while issue was closed.
Change committed as 223231

Powered by Google App Engine
This is Rietveld 408576698