Source/modules/screen_orientation/ScreenOrientationController.cpp - Issue 241203003: Screen Orientation: fire event on Window instead of Screen.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/screen_orientation/ScreenOrientationController.cpp

Issue 241203003: Screen Orientation: fire event on Window instead of Screen. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@ScreenOrientationUndefined

Patch Set: fix tests Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/screen_orientation/ScreenOrientationController.cpp

diff --git a/Source/modules/screen_orientation/ScreenOrientationController.cpp b/Source/modules/screen_orientation/ScreenOrientationController.cpp

index 9f1686db67f09080987a4209641514ece6d509f6..0de3398ec4bf0517ff840d695ff954157ac11cd0 100644

--- a/Source/modules/screen_orientation/ScreenOrientationController.cpp

+++ b/Source/modules/screen_orientation/ScreenOrientationController.cpp

@@ -41,7 +41,7 @@ void ScreenOrientationController::dispatchOrientationChangeEvent()

if (m_document.domWindow()

&& !m_document.activeDOMObjectsAreSuspended()

&& !m_document.activeDOMObjectsAreStopped())

- m_document.domWindow()->screen().dispatchEvent(Event::create(EventTypeNames::orientationchange));

+ m_document.domWindow()->dispatchEvent(Event::create(EventTypeNames::orientationchange));

}

const char* ScreenOrientationController::supplementName()

« no previous file with comments | « Source/modules/screen_orientation/ScreenOrientation.idl ('k') | no next file » | no next file with comments »