Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(593)

Side by Side Diff: Source/modules/screen_orientation/ScreenOrientationController.cpp

Issue 241203003: Screen Orientation: fire event on Window instead of Screen. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@ScreenOrientationUndefined
Patch Set: fix tests Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/modules/screen_orientation/ScreenOrientation.idl ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "config.h" 5 #include "config.h"
6 #include "modules/screen_orientation/ScreenOrientationController.h" 6 #include "modules/screen_orientation/ScreenOrientationController.h"
7 7
8 #include "core/dom/Document.h" 8 #include "core/dom/Document.h"
9 #include "core/events/Event.h" 9 #include "core/events/Event.h"
10 #include "core/frame/DOMWindow.h" 10 #include "core/frame/DOMWindow.h"
(...skipping 23 matching lines...) Expand all
34 { 34 {
35 // FIXME: We should listen for screen orientation change events only when th e page is visible. 35 // FIXME: We should listen for screen orientation change events only when th e page is visible.
36 ScreenOrientationDispatcher::instance().addController(this); 36 ScreenOrientationDispatcher::instance().addController(this);
37 } 37 }
38 38
39 void ScreenOrientationController::dispatchOrientationChangeEvent() 39 void ScreenOrientationController::dispatchOrientationChangeEvent()
40 { 40 {
41 if (m_document.domWindow() 41 if (m_document.domWindow()
42 && !m_document.activeDOMObjectsAreSuspended() 42 && !m_document.activeDOMObjectsAreSuspended()
43 && !m_document.activeDOMObjectsAreStopped()) 43 && !m_document.activeDOMObjectsAreStopped())
44 m_document.domWindow()->screen().dispatchEvent(Event::create(EventTypeNa mes::orientationchange)); 44 m_document.domWindow()->dispatchEvent(Event::create(EventTypeNames::orie ntationchange));
45 } 45 }
46 46
47 const char* ScreenOrientationController::supplementName() 47 const char* ScreenOrientationController::supplementName()
48 { 48 {
49 return "ScreenOrientationController"; 49 return "ScreenOrientationController";
50 } 50 }
51 51
52 void ScreenOrientationController::didChangeScreenOrientation(blink::WebScreenOri entationType orientation) 52 void ScreenOrientationController::didChangeScreenOrientation(blink::WebScreenOri entationType orientation)
53 { 53 {
54 if (orientation == m_orientation) 54 if (orientation == m_orientation)
55 return; 55 return;
56 56
57 m_orientation = orientation; 57 m_orientation = orientation;
58 dispatchOrientationChangeEvent(); 58 dispatchOrientationChangeEvent();
59 } 59 }
60 60
61 } // namespace WebCore 61 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/modules/screen_orientation/ScreenOrientation.idl ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698