LayoutTests/screen_orientation/lockOrientation-bad-argument.html - Issue 241203003: Screen Orientation: fire event on Window instead of Screen.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/screen_orientation/lockOrientation-bad-argument.html

Issue 241203003: Screen Orientation: fire event on Window instead of Screen. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@ScreenOrientationUndefined

Patch Set: fix tests Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/dom/Window/window-appendages-cleared-expected.txt ('k') | LayoutTests/screen_orientation/lockOrientation-bad-array-argument.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/screen_orientation/lockOrientation-bad-argument.html

diff --git a/LayoutTests/screen_orientation/lockOrientation-bad-argument.html b/LayoutTests/screen_orientation/lockOrientation-bad-argument.html

index 95456dbe7356b7605a236a39675d184f01fd8de8..affd4df2706a98995ca37f3f7dd2fd96a7af27b3 100644

--- a/LayoutTests/screen_orientation/lockOrientation-bad-argument.html

+++ b/LayoutTests/screen_orientation/lockOrientation-bad-argument.html

@@ -16,7 +16,7 @@ function completeTest() {

finishJSTest();

}

-screen.addEventListener("orientationchange", onOrientationChangeEvent);

+window.addEventListener("orientationchange", onOrientationChangeEvent);

function typeErrorEnum(argStr) {

return "TypeError: Failed to execute 'lockOrientation' on 'Screen': parameter 1 ('" + argStr + "') is not a valid enum value.";