Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2024)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

Issue 2410603002: Inflate toolbar layouts in ControlContainer (Closed)
Patch Set: fix custom tabs Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
index 3c7cb474730bf0084ca54c588ff732598bb12c08..3116949c23473f679519db5d8b5fbb21f2f64a68 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
@@ -166,6 +166,11 @@ public abstract class ChromeActivity extends AsyncInitializationActivity
*/
static final int NO_CONTROL_CONTAINER = -1;
+ /**
+ * No toolbar layout to inflate during initialization.
+ */
+ static final int NO_TOOLBAR_LAYOUT = -1;
+
private static final int RECORD_MULTI_WINDOW_SCREEN_WIDTH_DELAY_MS = 5000;
/**
@@ -358,6 +363,14 @@ public abstract class ChromeActivity extends AsyncInitializationActivity
toolbarContainerStub.setLayoutResource(controlContainerLayoutId);
toolbarContainerStub.inflate();
}
+
+ // Inflate the correct toolbar layout for the device.
gone 2016/10/12 17:37:45 Feels weird to not null check the controlContainer
mdjones 2016/10/12 20:17:14 Added check.
+ int toolbarLayoutId = getToolbarLayoutId();
+ if (toolbarLayoutId != NO_TOOLBAR_LAYOUT) {
+ ControlContainer controlContainer =
+ (ControlContainer) findViewById(R.id.control_container);
+ controlContainer.initWithToolbar(toolbarLayoutId);
+ }
} finally {
StrictMode.setThreadPolicy(oldPolicy);
}
@@ -464,6 +477,13 @@ public abstract class ChromeActivity extends AsyncInitializationActivity
}
/**
+ * @return The layout ID for the toolbar to use.
+ */
+ protected int getToolbarLayoutId() {
+ return NO_TOOLBAR_LAYOUT;
+ }
+
+ /**
* @return Whether contextual search is allowed for this activity or not.
*/
protected boolean isContextualSearchAllowed() {

Powered by Google App Engine
This is Rietveld 408576698