Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4343)

Unified Diff: chrome/android/java/res/layout/custom_tabs_toolbar.xml

Issue 2410603002: Inflate toolbar layouts in ControlContainer (Closed)
Patch Set: fix custom tabs Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/res/layout/custom_tabs_toolbar.xml
diff --git a/chrome/android/java/res/layout/custom_tabs_toolbar.xml b/chrome/android/java/res/layout/custom_tabs_toolbar.xml
index c2d9ce58864d2c079d49909aed27dc14325c71da..32efb4f5a86da876ad14bd3d8c141db59db917d8 100644
--- a/chrome/android/java/res/layout/custom_tabs_toolbar.xml
+++ b/chrome/android/java/res/layout/custom_tabs_toolbar.xml
@@ -5,7 +5,10 @@
<org.chromium.chrome.browser.toolbar.CustomTabToolbar
xmlns:android="http://schemas.android.com/apk/res/android"
- xmlns:chrome="http://schemas.android.com/apk/res-auto" >
+ xmlns:chrome="http://schemas.android.com/apk/res-auto"
+ android:layout_width="match_parent"
+ android:layout_height="@dimen/custom_tabs_control_container_height"
gone 2016/10/12 17:37:45 I don't think layout_width/height values actually
mdjones 2016/10/12 20:17:14 Not having these caused an inflation exception, I
+ android:id="@+id/toolbar" >
<ImageButton
android:id="@+id/close_button"
style="@style/ToolbarButton"

Powered by Google App Engine
This is Rietveld 408576698