Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 24079002: Consolidate the strings used by the CrOS/desktop user manager screen. (Closed)

Created:
7 years, 3 months ago by noms (inactive)
Modified:
7 years, 3 months ago
Reviewers:
xiyuan
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Consolidate the strings used by the CrOS/desktop user manager screen. BUG=NONE Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222172

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -41 lines) Patch
M chrome/app/chromeos_strings.grdp View 5 chunks +0 lines, -35 lines 0 comments Download
M chrome/app/generated_resources.grd View 4 chunks +13 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
noms (inactive)
Hi Xiyuan, I've moved the common strings between the CrOS and desktop user manager to ...
7 years, 3 months ago (2013-09-09 19:17:18 UTC) #1
xiyuan
lgtm
7 years, 3 months ago (2013-09-09 19:58:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noms@chromium.org/24079002/1
7 years, 3 months ago (2013-09-09 20:14:02 UTC) #3
commit-bot: I haz the power
7 years, 3 months ago (2013-09-10 01:40:00 UTC) #4
Message was sent while issue was closed.
Change committed as 222172

Powered by Google App Engine
This is Rietveld 408576698