Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(749)

Issue 24077007: Add support for the object-position CSS property. (Closed)

Created:
7 years, 3 months ago by mstensho (USE GERRIT)
Modified:
7 years, 3 months ago
Reviewers:
ojan
CC:
blink-reviews, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), jeez, eae+blinkwatch, dglazkov+blink, leviw+renderwatch, dstockwell, Timothy Loh, apavlov+blink_chromium.org, jchaffraix+rendering, darktears, Steve Block, dino_apple.com, Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Add support for the object-position CSS property. This is hidden behind an "experimental" runtime flag named "ObjectFitPosition", together with object-fit. This is an implementation of object-position as described in http://www.w3.org/TR/2012/CR-css3-images-20120417/#object-position Object-position is used to offset replaced content within its content box. Painting is always clipped against the content box, regardless of the "overflow" property. This property is useful together with object-fit (to achieve a difference between content box size and replaced content size, so that specifying alignment is interesting), but can also be used on its own. BUG=236333 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158155

Patch Set 1 #

Patch Set 2 : Rebase master #

Patch Set 3 : Report that object-position is animatable, so that we don't assert all the time. #

Patch Set 4 : Rebase master again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+839 lines, -32 lines) Patch
M LayoutTests/animations/resources/animation-test-helpers.js View 1 chunk +13 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/object-position.html View 1 chunk +49 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/object-position-expected.html View 1 chunk +53 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/object-position-svg.html View 1 chunk +50 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/object-position-svg-expected.html View 1 chunk +53 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/object-position-with-fit-contain.html View 1 chunk +50 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/object-position-with-fit-contain-expected.html View 1 chunk +53 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/object-position-with-fit-cover.html View 1 chunk +50 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/object-position-with-fit-cover-expected.html View 1 chunk +53 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/object-position-with-fit-none.html View 1 chunk +50 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/object-position-with-fit-none-expected.html View 1 chunk +53 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/parsing-object-position.html View 1 chunk +80 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/parsing-object-position-expected.txt View 1 chunk +52 lines, -0 lines 0 comments Download
A + LayoutTests/fast/css/resources/circle-small.svg View 1 chunk +2 lines, -2 lines 0 comments Download
A LayoutTests/transitions/object-position-transition.html View 1 chunk +34 lines, -0 lines 0 comments Download
A LayoutTests/transitions/object-position-transition-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/webexposed/css-properties-as-js-properties-expected.txt View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/animation/css/CSSAnimations.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/CSSComputedStyleDeclaration.cpp View 1 2 3 3 chunks +9 lines, -1 line 0 comments Download
M Source/core/css/CSSParser.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/css/CSSParser-in.cpp View 1 2 3 3 chunks +18 lines, -2 lines 0 comments Download
M Source/core/css/CSSProperties.in View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/CSSProperty.cpp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/CSSPropertyNames.in View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/Pair.h View 1 chunk +29 lines, -12 lines 0 comments Download
M Source/core/css/resolver/StyleBuilderCustom.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/resolver/StyleBuilderCustom.cpp View 1 2 3 2 chunks +10 lines, -0 lines 0 comments Download
M Source/core/page/RuntimeCSSEnabled.cpp View 1 2 3 2 chunks +5 lines, -1 line 0 comments Download
M Source/core/page/UseCounter.cpp View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/page/animation/CSSPropertyAnimation.cpp View 2 chunks +7 lines, -0 lines 0 comments Download
A + Source/core/platform/LengthPoint.h View 1 chunk +36 lines, -8 lines 0 comments Download
M Source/core/rendering/RenderImage.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderReplaced.cpp View 1 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/rendering/style/RenderStyle.h View 1 2 3 3 chunks +3 lines, -0 lines 0 comments Download
M Source/core/rendering/style/RenderStyle.cpp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/rendering/style/StyleRareNonInheritedData.h View 1 2 3 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/rendering/style/StyleRareNonInheritedData.cpp View 1 2 3 3 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
mstensho (USE GERRIT)
This is another attempt to land object-position. It's a continuation of https://codereview.chromium.org/22839023/ (the last patch ...
7 years, 3 months ago (2013-09-20 15:43:20 UTC) #1
ojan
lgtm
7 years, 3 months ago (2013-09-20 20:18:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mstensho@opera.com/24077007/6001
7 years, 3 months ago (2013-09-20 20:21:47 UTC) #3
commit-bot: I haz the power
Failed to apply patch for Source/core/page/UseCounter.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 3 months ago (2013-09-20 20:22:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mstensho@opera.com/24077007/13001
7 years, 3 months ago (2013-09-20 21:51:38 UTC) #5
commit-bot: I haz the power
7 years, 3 months ago (2013-09-21 04:25:26 UTC) #6
Message was sent while issue was closed.
Change committed as 158155

Powered by Google App Engine
This is Rietveld 408576698