Remove ShouldSetAttached flag to lazyAttach

Remove ShouldSetAttached flag to lazyAttach

This flag is only used by HTMLFrameElementBase and is suspect since calling
lazyAttach with this flag is the same as calling setNeedsStyleRecalc(). Frames
appear to use this so that synchronous JS that runs from javascipt: URLs can
trigger an attach of the frame and get at its renderer. We can replace this one
caller with setNeedsStyleRecalc().

In the future we should merge the lazyAttach logic into insertedInto so that by
the time the didNotifySubtreeInsertions callback runs any JS will observe the
whole tree attach.

[eseidel, 2013-09-08 22:20:35]

lgtm

[commit-bot: I haz the power, 2013-09-08 22:20:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/esprehn@chromium.org/24066002/1

[commit-bot: I haz the power, 2013-09-09 00:00:32]

Change committed as 157423

[esprehn, 2013-09-10 08:57:34]

On 2013/09/09 00:00:32, I haz the power (commit-bot) wrote:
> Change committed as 157423

This change was apparently reverted:
http://src.chromium.org/viewvc/blink/?view=revision&revision=157445

but the revert was landed without uploading to Rietveld or filing a bug so who
knows what happened. I only just noticed when I saw the code had reappeared...
:(

[esprehn, 2013-09-10 09:15:43]

On 2013/09/10 08:57:34, esprehn wrote:
> On 2013/09/09 00:00:32, I haz the power (commit-bot) wrote:
> > Change committed as 157423
> 
> This change was apparently reverted:
> http://src.chromium.org/viewvc/blink/?view=revision&revision=157445
> 
> but the revert was landed without uploading to Rietveld or filing a bug so who
> knows what happened. I only just noticed when I saw the code had reappeared...
> :(

Eugene helped me figure it out, seems there was some kind of gardening mishap
where the issue was created but when it was landed the issue wasn't updated or
mailed.

https://codereview.chromium.org/23528005/

I apparently tripped up the ASSERT about what children are allowed to be already
attached when doing an attach.

[commit-bot: I haz the power, 2013-09-11 06:18:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/esprehn@chromium.org/24066002/14001

[commit-bot: I haz the power, 2013-09-11 06:53:04]

Retried try job too often on linux_blink_rel for step(s) webkit_tests,
webkit_unit_tests, weborigin_unittests, wtf_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin...

[commit-bot: I haz the power, 2013-09-11 07:12:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/esprehn@chromium.org/24066002/14001