Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Side by Side Diff: Source/core/dom/Node.cpp

Issue 24066002: Remove ShouldSetAttached flag to lazyAttach (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Use setNeedsStyleRecalc() in HTMLFrameElementBase Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/dom/Node.h ('k') | Source/core/html/HTMLFrameElementBase.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved.
6 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies) 6 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
7 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 7 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 756 matching lines...) Expand 10 before | Expand all | Expand 10 after
767 setFlag(NotifyRendererWithIdenticalStyles); 767 setFlag(NotifyRendererWithIdenticalStyles);
768 768
769 StyleChangeType existingChangeType = styleChangeType(); 769 StyleChangeType existingChangeType = styleChangeType();
770 if (changeType > existingChangeType) 770 if (changeType > existingChangeType)
771 setStyleChange(changeType); 771 setStyleChange(changeType);
772 772
773 if (existingChangeType == NoStyleChange) 773 if (existingChangeType == NoStyleChange)
774 markAncestorsWithChildNeedsStyleRecalc(); 774 markAncestorsWithChildNeedsStyleRecalc();
775 } 775 }
776 776
777 void Node::lazyAttach(ShouldSetAttached shouldSetAttached) 777 void Node::lazyAttach()
778 { 778 {
779 markAncestorsWithChildNeedsStyleRecalc(); 779 markAncestorsWithChildNeedsStyleRecalc();
780 for (Node* node = this; node; node = NodeTraversal::next(node, this)) { 780 for (Node* node = this; node; node = NodeTraversal::next(node, this)) {
781 node->setStyleChange(LazyAttachStyleChange); 781 node->setStyleChange(LazyAttachStyleChange);
782 if (node->isContainerNode()) 782 if (node->isContainerNode())
783 node->setChildNeedsStyleRecalc(); 783 node->setChildNeedsStyleRecalc();
784 // FIXME: This flag is only used by HTMLFrameElementBase and doesn't loo k needed.
785 if (shouldSetAttached == SetAttached)
786 node->setAttached();
787 for (ShadowRoot* root = node->youngestShadowRoot(); root; root = root->o lderShadowRoot()) 784 for (ShadowRoot* root = node->youngestShadowRoot(); root; root = root->o lderShadowRoot())
788 root->lazyAttach(shouldSetAttached); 785 root->lazyAttach();
789 } 786 }
790 } 787 }
791 788
792 Node* Node::focusDelegate() 789 Node* Node::focusDelegate()
793 { 790 {
794 return this; 791 return this;
795 } 792 }
796 793
797 bool Node::shouldHaveFocusAppearance() const 794 bool Node::shouldHaveFocusAppearance() const
798 { 795 {
(...skipping 1881 matching lines...) Expand 10 before | Expand all | Expand 10 after
2680 node->showTreeForThis(); 2677 node->showTreeForThis();
2681 } 2678 }
2682 2679
2683 void showNodePath(const WebCore::Node* node) 2680 void showNodePath(const WebCore::Node* node)
2684 { 2681 {
2685 if (node) 2682 if (node)
2686 node->showNodePathForThis(); 2683 node->showNodePathForThis();
2687 } 2684 }
2688 2685
2689 #endif 2686 #endif
OLDNEW
« no previous file with comments | « Source/core/dom/Node.h ('k') | Source/core/html/HTMLFrameElementBase.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698