Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1366)

Issue 24045002: Remove some HTMLObjectElement logic from FrameLoader (Closed)

Created:
7 years, 3 months ago by Nate Chapin
Modified:
7 years, 3 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, dglazkov+blink, Nate Chapin, eae+blinkwatch, adamk+blink_chromium.org, gavinp+loader_chromium.org
Visibility:
Public.

Description

Remove some HTMLObjectElement logic from FrameLoader BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157411

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -32 lines) Patch
M Source/core/html/HTMLFrameOwnerElement.h View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/html/HTMLObjectElement.h View 2 chunks +3 lines, -1 line 0 comments Download
M Source/core/loader/DocumentLoader.cpp View 2 chunks +3 lines, -9 lines 0 comments Download
M Source/core/loader/FrameLoader.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/loader/FrameLoader.cpp View 4 chunks +3 lines, -18 lines 0 comments Download
M Source/core/loader/HistoryController.cpp View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Nate Chapin
7 years, 3 months ago (2013-09-06 21:05:34 UTC) #1
abarth-chromium
lgtm
7 years, 3 months ago (2013-09-07 20:39:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet@chromium.org/24045002/1
7 years, 3 months ago (2013-09-07 20:40:10 UTC) #3
commit-bot: I haz the power
7 years, 3 months ago (2013-09-07 21:46:48 UTC) #4
Message was sent while issue was closed.
Change committed as 157411

Powered by Google App Engine
This is Rietveld 408576698