Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(759)

Unified Diff: Source/core/loader/FrameLoader.cpp

Issue 24045002: Remove some HTMLObjectElement logic from FrameLoader (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/loader/FrameLoader.h ('k') | Source/core/loader/HistoryController.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/loader/FrameLoader.cpp
diff --git a/Source/core/loader/FrameLoader.cpp b/Source/core/loader/FrameLoader.cpp
index 6b6b024995051ce2d3770579d9e8d78ab636a502..9ad3b2472247ed4c05f75f6c249adaf8078b8083 100644
--- a/Source/core/loader/FrameLoader.cpp
+++ b/Source/core/loader/FrameLoader.cpp
@@ -51,7 +51,7 @@
#include "core/history/BackForwardController.h"
#include "core/history/HistoryItem.h"
#include "core/html/HTMLFormElement.h"
-#include "core/html/HTMLObjectElement.h"
+#include "core/html/HTMLFrameOwnerElement.h"
#include "core/html/parser/HTMLParserIdioms.h"
#include "core/inspector/InspectorController.h"
#include "core/inspector/InspectorInstrumentation.h"
@@ -517,15 +517,6 @@ void FrameLoader::setOpener(Frame* opener)
m_frame->document()->initSecurityContext();
}
-// FIXME: This does not belong in FrameLoader!
-void FrameLoader::handleFallbackContent()
-{
- HTMLFrameOwnerElement* owner = m_frame->ownerElement();
- if (!owner || !owner->hasTagName(objectTag))
- return;
- toHTMLObjectElement(owner)->renderFallbackContent();
-}
-
bool FrameLoader::allowPlugins(ReasonForCallingAllowPlugins reason)
{
Settings* settings = m_frame->settings();
@@ -963,12 +954,6 @@ void FrameLoader::closeOldDataSources()
m_client->dispatchWillClose();
}
-bool FrameLoader::isHostedByObjectElement() const
-{
- HTMLFrameOwnerElement* owner = m_frame->ownerElement();
- return owner && owner->hasTagName(objectTag);
-}
-
bool FrameLoader::isLoadingMainFrame() const
{
Page* page = m_frame->page();
@@ -1303,8 +1288,8 @@ void FrameLoader::receivedMainResourceError(const ResourceError& error)
// FIXME: We really ought to be able to just check for isCancellation() here, but there are some
// ResourceErrors that setIsCancellation() but aren't created by ResourceError::cancelledError().
ResourceError c(ResourceError::cancelledError(KURL()));
- if (error.errorCode() != c.errorCode() || error.domain() != c.domain())
- handleFallbackContent();
+ if ((error.errorCode() != c.errorCode() || error.domain() != c.domain()) && m_frame->ownerElement())
+ m_frame->ownerElement()->renderFallbackContent();
checkCompleted();
if (m_frame->page())
« no previous file with comments | « Source/core/loader/FrameLoader.h ('k') | Source/core/loader/HistoryController.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698