chrome/renderer/translate/translate_helper.cc - Issue 24024004: Translate: element API callback interface change

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/translate/translate_helper.cc

Issue 24024004: Translate: element API callback interface change (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rename hash table Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/translate/translate_helper.cc

diff --git a/chrome/renderer/translate/translate_helper.cc b/chrome/renderer/translate/translate_helper.cc

index ee73f02c8180eace9d80312cf6b43c5ad9e6c878..418198bcd1b6fc5f43238d9efdaa389dc72a1438 100644

--- a/chrome/renderer/translate/translate_helper.cc

+++ b/chrome/renderer/translate/translate_helper.cc

@@ -391,6 +391,7 @@ void TranslateHelper::CheckTranslateStatus() {

// First check if there was an error.

if (HasTranslationFailed()) {

+ // TODO(toyoshim): Check |errorCode| of translate.js and notify it here.

NotifyBrowserTranslationFailed(TranslateErrors::TRANSLATION_ERROR);

return; // There was an error.

}