Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Unified Diff: chrome/common/translate/translate_errors.h

Issue 24024004: Translate: element API callback interface change (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rename hash table Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/translate/translate_errors.h
diff --git a/chrome/common/translate/translate_errors.h b/chrome/common/translate/translate_errors.h
index 24421dfff689e5a6d3ae6e783066b51ccb32462a..af011aaeb5d8eaa7435eb193dae5071512460fc6 100644
--- a/chrome/common/translate/translate_errors.h
+++ b/chrome/common/translate/translate_errors.h
@@ -7,6 +7,7 @@
// This file consolidates all the error types for translation of a page.
// Note: TranslateErrors is used for UMA and translate_internals.js.
+// Assigned numbers should be changed because the number is binded to UMA value.
// enum TranslateError in histograms.xml and errorStrs in translate_internals.js
// should be updated when the type is updated.
@@ -14,14 +15,18 @@ class TranslateErrors {
public:
enum Type {
NONE = 0,
- NETWORK, // No connectivity.
- INITIALIZATION_ERROR, // The translation script failed to initialize.
- UNKNOWN_LANGUAGE, // The page's language could not be detected.
- UNSUPPORTED_LANGUAGE, // The server detected a language that the browser
- // does not know.
- IDENTICAL_LANGUAGES, // The original and target languages are the same.
- TRANSLATION_ERROR, // An error was reported by the translation script
- // during translation.
+ NETWORK, // No connectivity.
+ INITIALIZATION_ERROR, // The translation script failed to initialize.
+ UNKNOWN_LANGUAGE, // The page's language could not be detected.
+ UNSUPPORTED_LANGUAGE, // The server detected a language that the browser
+ // does not know.
+ IDENTICAL_LANGUAGES, // The original and target languages are the same.
+ TRANSLATION_ERROR, // An error was reported by the translation script
+ // during translation.
+ TRANSLATION_TIMEOUT, // The library doesn't finish the translation.
+ UNEXPECTED_SCRIPT_ERROR, // The library raises an unexpected exception.
+ BAD_ORIGIN, // The library is blocked because of bad origin.
+ SCRIPT_LOAD_ERROR, // Loader fails to load a dependent JavaScript.
TRANSLATE_ERROR_MAX,
};

Powered by Google App Engine
This is Rietveld 408576698