Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Unified Diff: chrome/browser/value_store/value_store_frontend.cc

Issue 24021002: Propagate more information about ValueStore errors to callers, notably an (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: add Pass*() Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/value_store/value_store_frontend.cc
diff --git a/chrome/browser/value_store/value_store_frontend.cc b/chrome/browser/value_store/value_store_frontend.cc
index 3930d4520970f7e7d492f130f48617ef65179bbc..7ffb4ccfb6df898144c1dcfa34f5a880275d31fd 100644
--- a/chrome/browser/value_store/value_store_frontend.cc
+++ b/chrome/browser/value_store/value_store_frontend.cc
@@ -41,10 +41,10 @@ class ValueStoreFrontend::Backend : public base::RefCountedThreadSafe<Backend> {
// callback.
scoped_ptr<base::Value> value;
if (!result->HasError()) {
- result->settings()->RemoveWithoutPathExpansion(key, &value);
+ result->settings().RemoveWithoutPathExpansion(key, &value);
} else {
- LOG(INFO) << "Reading " << key << " from " << db_path_.value()
- << " failed: " << result->error();
+ LOG(WARNING) << "Reading " << key << " from " << db_path_.value()
+ << " failed: " << result->error().message;
}
BrowserThread::PostTask(BrowserThread::UI, FROM_HERE,
« no previous file with comments | « chrome/browser/value_store/value_store.cc ('k') | chrome/browser/value_store/value_store_frontend_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698