Propagate more information about ValueStore errors to callers, notably an

chrome/browser/value_store/value_store_frontend.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/value_store/value_store_frontend.h"
 
 #include "base/bind.h"
 #include "base/debug/trace_event.h"
 #include "base/files/file_path.h"
 #include "base/logging.h"
@@ skipping 23 matching lines @@
 
   void Get(const std::string& key,
            const ValueStoreFrontend::ReadCallback& callback) {
     DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));
     ValueStore::ReadResult result = storage_->Get(key);
 
     // Extract the value from the ReadResult and pass ownership of it to the
     // callback.
     scoped_ptr<base::Value> value;
     if (!result->HasError()) {
-      result->settings()->RemoveWithoutPathExpansion(key, &value);
+      result->settings().RemoveWithoutPathExpansion(key, &value);
     } else {
-      LOG(INFO) << "Reading " << key << " from " << db_path_.value()
-                << " failed: " << result->error();
+      LOG(WARNING) << "Reading " << key << " from " << db_path_.value()
+                   << " failed: " << result->error().message;
     }
 
     BrowserThread::PostTask(BrowserThread::UI, FROM_HERE,
         base::Bind(&ValueStoreFrontend::Backend::RunCallback,
                    this, callback, base::Passed(&value)));
   }
 
   void Set(const std::string& key, scoped_ptr<base::Value> value) {
     DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));
     // We don't need the old value, so skip generating changes.
@@ skipping 76 matching lines @@
                  backend_, key, base::Passed(&value)));
 }
 
 void ValueStoreFrontend::Remove(const std::string& key) {
   DCHECK(CalledOnValidThread());
 
   BrowserThread::PostTask(BrowserThread::FILE, FROM_HERE,
       base::Bind(&ValueStoreFrontend::Backend::Remove,
                  backend_, key));
 }