Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23983034: [oilpan] Handlify Node raw pointers in html/ and subclasses of dom/LiveNodeList. (Closed)

Created:
7 years, 3 months ago by zerny-chromium
Modified:
7 years, 3 months ago
CC:
blink-reviews, haraken, adamk+oilpan_chromium.org, Mads Ager (chromium), abarth-chromium
Visibility:
Public.

Description

[oilpan] Handlify Node raw pointers in html/ and subclasses of dom/LiveNodeList. R=haraken@chromium.org BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157779

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -66 lines) Patch
M Source/bindings/v8/custom/V8HTMLAllCollectionCustom.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/ChildNodeList.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/ChildNodeList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/ClassNodeList.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/ClassNodeList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/ContainerNodeAlgorithms.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/LiveNodeList.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/dom/NameNodeList.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/NameNodeList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/NodeRareData.h View 5 chunks +5 lines, -5 lines 0 comments Download
M Source/core/dom/TagNodeList.h View 4 chunks +5 lines, -5 lines 0 comments Download
M Source/core/dom/TagNodeList.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLAllCollection.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLAllCollection.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/core/html/HTMLCollection.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLCollection.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLFormControlsCollection.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLFormControlsCollection.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLFrameOwnerElement.h View 3 chunks +8 lines, -5 lines 1 comment Download
M Source/core/html/HTMLNameCollection.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLNameCollection.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLOptionsCollection.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLOptionsCollection.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLTableRowsCollection.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLTableRowsCollection.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/LabelsNodeList.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/LabelsNodeList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/RadioNodeList.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/RadioNodeList.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
zerny-chromium
7 years, 3 months ago (2013-09-12 20:01:12 UTC) #1
haraken
LGTM https://codereview.chromium.org/23983034/diff/1/Source/core/html/HTMLFrameOwnerElement.h File Source/core/html/HTMLFrameOwnerElement.h (right): https://codereview.chromium.org/23983034/diff/1/Source/core/html/HTMLFrameOwnerElement.h#newcode110 Source/core/html/HTMLFrameOwnerElement.h:110: // All nodes in the collection are traced ...
7 years, 3 months ago (2013-09-12 20:08:14 UTC) #2
zerny-chromium
On 2013/09/12 20:08:14, haraken wrote: > LGTM > > https://codereview.chromium.org/23983034/diff/1/Source/core/html/HTMLFrameOwnerElement.h > File Source/core/html/HTMLFrameOwnerElement.h (right): > ...
7 years, 3 months ago (2013-09-13 15:16:32 UTC) #3
zerny-chromium
7 years, 3 months ago (2013-09-13 19:58:45 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 manually as r157779 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698