Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Side by Side Diff: Source/bindings/v8/custom/V8HTMLAllCollectionCustom.cpp

Issue 23983034: [oilpan] Handlify Node raw pointers in html/ and subclasses of dom/LiveNodeList. (Closed) Base URL: svn://svn.chromium.org/blink/branches/oilpan
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
113 113
114 if (args.Length() == 1) 114 if (args.Length() == 1)
115 return getItem(imp, args[0], args); 115 return getItem(imp, args[0], args);
116 116
117 // If there is a second argument it is the index of the item we want. 117 // If there is a second argument it is the index of the item we want.
118 String name = toWebCoreString(args[0]); 118 String name = toWebCoreString(args[0]);
119 v8::Local<v8::Uint32> index = args[1]->ToArrayIndex(); 119 v8::Local<v8::Uint32> index = args[1]->ToArrayIndex();
120 if (index.IsEmpty()) 120 if (index.IsEmpty())
121 return v8::Undefined(); 121 return v8::Undefined();
122 122
123 if (Node* node = imp->namedItemWithIndex(name, index->Uint32Value())) 123 if (Handle<Node> node = imp->namedItemWithIndex(name, index->Uint32Value()))
124 return toV8Fast(Handle<Node>(node), args, imp); 124 return toV8Fast(node, args, imp);
125 125
126 return v8::Undefined(); 126 return v8::Undefined();
127 } 127 }
128 128
129 } // namespace WebCore 129 } // namespace WebCore
OLDNEW
« no previous file with comments | « no previous file | Source/core/dom/ChildNodeList.h » ('j') | Source/core/html/HTMLFrameOwnerElement.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698