Issue 23979003: Replace swap with Pass() on setters in drive_api_parser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23979003: Replace swap with Pass() on setters in drive_api_parser. (Closed)

Created:
7 years, 3 months ago by tzik

Modified:
7 years, 3 months ago

Reviewers:
kinaba

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Replace swap with Pass() on setters in drive_api_parser. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221716

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -28 lines)			Patch
M	chrome/browser/chromeos/file_manager/file_tasks_unittest.cc	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/google_apis/drive_api_parser.h	View		5 chunks	+18 lines, -18 lines	0 comments	Download
M	chrome/browser/google_apis/drive_api_parser.cc	View	1	3 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/sync_file_system/drive_backend/metadata_database_unittest.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (0 generated)

tzik

PTAL, Kinaba-san. These setters puts their old value to the argument. IMO, this is unexpected ...

7 years, 3 months ago (2013-09-06 11:41:38 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/23979003/3001

7 years, 3 months ago (2013-09-06 12:53:06 UTC) #3

Message was sent while issue was closed.

Change committed as 221716