Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1233)

Unified Diff: chrome/browser/google_apis/drive_api_parser.cc

Issue 23979003: Replace swap with Pass() on setters in drive_api_parser. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/google_apis/drive_api_parser.cc
diff --git a/chrome/browser/google_apis/drive_api_parser.cc b/chrome/browser/google_apis/drive_api_parser.cc
index 1bea266382a28d0ff020d7b88c30f2bc476284f7..62cec899a60ee579ee0ce7e996cf08051e01b28b 100644
--- a/chrome/browser/google_apis/drive_api_parser.cc
+++ b/chrome/browser/google_apis/drive_api_parser.cc
@@ -408,22 +408,22 @@ scoped_ptr<AppResource> AppResource::CreateFromInstalledApp(
{
ScopedVector<std::string> primary_mimetypes(
CopyScopedVectorString(installed_app.primary_mimetypes()));
- resource->set_primary_mimetypes(&primary_mimetypes);
+ resource->set_primary_mimetypes(primary_mimetypes.Pass());
}
{
ScopedVector<std::string> secondary_mimetypes(
CopyScopedVectorString(installed_app.secondary_mimetypes()));
- resource->set_secondary_mimetypes(&secondary_mimetypes);
+ resource->set_secondary_mimetypes(secondary_mimetypes.Pass());
}
{
ScopedVector<std::string> primary_file_extensions(
CopyScopedVectorString(installed_app.primary_extensions()));
- resource->set_primary_file_extensions(&primary_file_extensions);
+ resource->set_primary_file_extensions(primary_file_extensions.Pass());
}
{
ScopedVector<std::string> secondary_file_extensions(
CopyScopedVectorString(installed_app.secondary_extensions()));
- resource->set_secondary_file_extensions(&secondary_file_extensions);
+ resource->set_secondary_file_extensions(secondary_file_extensions.Pass());
}
{
@@ -433,7 +433,7 @@ scoped_ptr<AppResource> AppResource::CreateFromInstalledApp(
for (size_t i = 0; i < app_icons.size(); ++i) {
icons.push_back(DriveAppIcon::CreateFromAppIcon(*app_icons[i]).release());
}
- resource->set_icons(&icons);
+ resource->set_icons(icons.Pass());
}
// supports_import, installed and authorized are not supported in
@@ -490,7 +490,7 @@ scoped_ptr<AppList> AppList::CreateFromAccountMetadata(
app_resources.push_back(
AppResource::CreateFromInstalledApp(*installed_apps[i]).release());
}
- resource->set_items(&app_resources);
+ resource->set_items(app_resources.Pass());
// etag is not supported in AccountMetadata.

Powered by Google App Engine
This is Rietveld 408576698