Delete unneeded pending entries in DidFailProvisionalLoad to prevent a spoof.

Delete unneeded pending entries in DidFailProvisionalLoad to prevent a spoof.

BUG=280512
BUG=278899
TEST=See bug for repro steps.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222146

[Charlie Reis, 2013-09-05 00:25:22]

Brett, can you take a look?  My reasoning is in comment 7 of
http://crbug.com/280512.

[Charlie Reis, 2013-09-05 18:41:10]

Fixed an assumption in a unit test as well, so the bots seem happy now.

[brettw, 2013-09-05 23:16:21]

lgtm

[commit-bot: I haz the power, 2013-09-05 23:24:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/creis@chromium.org/23978003/8001

[commit-bot: I haz the power, 2013-09-06 07:24:01]

Retried try job too often on win7_aura for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...

[Charlie Reis, 2013-09-06 23:42:21]

Brett, can you take another look?  The previous patch was failing
SafeBrowsingBlockingPageTest.MalwareRedirectCanceled on Windows, since it turned
out that it was clearing the transient entry as well when an interstitial page
was showing.

I'm less thrilled about exposing a separate DiscardPendingEntry(), but this gets
us back to the state we were in (i.e., have a transient but no pending) before I
started creating renderer-initiated pending entries for http://crbug.com/9682.

[brettw, 2013-09-09 20:56:15]

lgtm

[commit-bot: I haz the power, 2013-09-09 21:01:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/creis@chromium.org/23978003/32001

[commit-bot: I haz the power, 2013-09-10 00:11:51]

Change committed as 222146