content/browser/web_contents/navigation_controller_impl.h - Issue 23978003: Delete unneeded pending entries in DidFailProvisionalLoad to prevent a spoof.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/navigation_controller_impl.h

Issue 23978003: Delete unneeded pending entries in DidFailProvisionalLoad to prevent a spoof. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Only clear the pending entry, not the transient. Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/web_contents/navigation_controller_impl.h

diff --git a/content/browser/web_contents/navigation_controller_impl.h b/content/browser/web_contents/navigation_controller_impl.h

index bef3be2202f16765ea2894f143bf2d76c2f0427c..2f0d71ea966fe280b53c424d0452a8ac501cb5a7 100644

--- a/content/browser/web_contents/navigation_controller_impl.h

+++ b/content/browser/web_contents/navigation_controller_impl.h

@@ -289,10 +289,13 @@ class CONTENT_EXPORT NavigationControllerImpl

// Removes the entry at |index|, as long as it is not the current entry.

void RemoveEntryAtIndexInternal(int index);

- // Discards the pending and transient entries.

+ // Discards both the pending and transient entries.

void DiscardNonCommittedEntriesInternal();

- // Discards the transient entry.

+ // Discards only the pending entry.

+ void DiscardPendingEntry();

+ // Discards only the transient entry.

void DiscardTransientEntry();

// If we have the maximum number of entries, remove the oldest one in

« no previous file with comments | « no previous file | content/browser/web_contents/navigation_controller_impl.cc » ('j') | no next file with comments »