Issue 23956003: DevTools: Add a fallback for console message callframe linkifying when scriptId could not be resolv…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23956003: DevTools: Add a fallback for console message callframe linkifying when scriptId could not be resolv… (Closed)

Created:
7 years, 3 months ago by vsevik

Modified:
7 years, 3 months ago

Reviewers:
pfeldman

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

DevTools: Add a fallback for console message callframe linkifying when scriptId could not be resolved. No test is added as I was only able to reproduce it in DevTools on DevTools. R=pfeldman Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157370

Patch Set 1 #

Patch Set 2 : Comments addressed #

Patch Set 3 : Removed unresolved call frame altogether #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -9 lines)			Patch
A +	LayoutTests/inspector/console/console-error-on-call-frame.html	View	1	2 chunks	+12 lines, -9 lines	0 comments	Download
A	LayoutTests/inspector/console/console-error-on-call-frame-expected.txt	View	1 2	1 chunk	+14 lines, -0 lines	0 comments	Download
M	Source/devtools/front_end/ConsoleMessage.js	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/23956003/8001

7 years, 3 months ago (2013-09-06 13:48:27 UTC) #5

Message was sent while issue was closed.

Change committed as 157370

Expand Messages | Collapse Messages