Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Unified Diff: Source/devtools/front_end/ConsoleMessage.js

Issue 23956003: DevTools: Add a fallback for console message callframe linkifying when scriptId could not be resolv… (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Removed unresolved call frame altogether Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/inspector/console/console-error-on-call-frame-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/ConsoleMessage.js
diff --git a/Source/devtools/front_end/ConsoleMessage.js b/Source/devtools/front_end/ConsoleMessage.js
index abe81c9fdd56ec5603d1700c2e3a1f331eec597c..48f8c167dd662859550f43f34fe0f1e8a358d2eb 100644
--- a/Source/devtools/front_end/ConsoleMessage.js
+++ b/Source/devtools/front_end/ConsoleMessage.js
@@ -806,6 +806,8 @@ WebInspector.ConsoleMessageImpl.prototype = {
if (frame.scriptId) {
content.appendChild(document.createTextNode(" "));
var urlElement = this._linkifyCallFrame(frame);
+ if (!urlElement)
+ continue;
content.appendChild(urlElement);
}
« no previous file with comments | « LayoutTests/inspector/console/console-error-on-call-frame-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698