PNaCl Coordinator: Run StreamEnd RPC even if StreamChunk fails

PNaCl Coordinator: Run StreamEnd RPC even if StreamChunk fails

If the StreamChunk RPC fails, the coordinator currently reports an error
and aborts immedately, but this leaves no useful information for the
user or developer. Instead, call the StreamEnd RPC which returns a
string describing the error (but only if the RPC error was
reported by the application on the other end, and not an
error with the RPC itself).
Also disable the PnaclErrorHandling test until the translator change in
https://codereview.chromium.org/23753003/ rolls into Chrome
(since it, combined with this change, will improve the error message
reported by the translator).

R=jvoung@chromium.org
BUG= https://code.google.com/p/nativeclient/issues/detail?id=3519
TEST=NaClBrowserTestPnacl.ErrorHandling

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222240

[Derek Schuff, 2013-09-09 23:02:43]

+ncbray for chrome/test/nacl OWNERS

[Nick Bray (chromium), 2013-09-09 23:23:22]

Owners LGTM rubberstamp.

[jvoung (off chromium), 2013-09-09 23:24:28]

https://codereview.chromium.org/23946004/diff/1/chrome/test/nacl/nacl_browser...
File chrome/test/nacl/nacl_browsertest.cc (right):

https://codereview.chromium.org/23946004/diff/1/chrome/test/nacl/nacl_browser...
chrome/test/nacl/nacl_browsertest.cc:123: DISABLED_PnaclErrorHandling) {
You could also just change chrome/test/data/nacl/pnacl_error_handling/ to just
omit the "bad_pexe" case for now.

https://codereview.chromium.org/23946004/diff/1/ppapi/native_client/src/trust...
File ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.cc (right):

https://codereview.chromium.org/23946004/diff/1/ppapi/native_client/src/trust...
ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.cc:203: if
(llc_subprocess_->srpc_client()->GetLastError() !=
Could leave a comment about the difference in error handling.

[Derek Schuff, 2013-09-09 23:45:40]

https://codereview.chromium.org/23946004/diff/1/chrome/test/nacl/nacl_browser...
File chrome/test/nacl/nacl_browsertest.cc (right):

https://codereview.chromium.org/23946004/diff/1/chrome/test/nacl/nacl_browser...
chrome/test/nacl/nacl_browsertest.cc:123: DISABLED_PnaclErrorHandling) {
On 2013/09/09 23:24:28, jvoung (cr) wrote:
> You could also just change chrome/test/data/nacl/pnacl_error_handling/ to just
> omit the "bad_pexe" case for now.

Done.

https://codereview.chromium.org/23946004/diff/1/ppapi/native_client/src/trust...
File ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.cc (right):

https://codereview.chromium.org/23946004/diff/1/ppapi/native_client/src/trust...
ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.cc:203: if
(llc_subprocess_->srpc_client()->GetLastError() !=
On 2013/09/09 23:24:28, jvoung (cr) wrote:
> Could leave a comment about the difference in error handling.

Done.

[jvoung (off chromium), 2013-09-09 23:51:37]

lgtm

[commit-bot: I haz the power, 2013-09-10 00:16:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dschuff@chromium.org/23946004/12001

[commit-bot: I haz the power, 2013-09-10 09:22:49]

Change committed as 222240