Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Unified Diff: chrome/test/data/nacl/pnacl_error_handling/pnacl_error_handling.html

Issue 23946004: PNaCl Coordinator: Run StreamEnd RPC even if StreamChunk fails (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/nacl/pnacl_error_handling/pnacl_error_handling.html
diff --git a/chrome/test/data/nacl/pnacl_error_handling/pnacl_error_handling.html b/chrome/test/data/nacl/pnacl_error_handling/pnacl_error_handling.html
index 0352de3cd0e2380a518cc23fee0f5221b8e819e1..b4eacbab5df17660385cff58ff6d30a0cd514093 100644
--- a/chrome/test/data/nacl/pnacl_error_handling/pnacl_error_handling.html
+++ b/chrome/test/data/nacl/pnacl_error_handling/pnacl_error_handling.html
@@ -22,12 +22,14 @@
function declareTests(tester) {
// 'bad_pexe' loads a manifest, then loads a pexe that is invalid.
- badLoadTest(
- tester,
- 'bad_pexe',
- 'pnacl_bad_pexe.nmf',
- 'application/x-pnacl',
- 'NaCl module load failed: PnaclCoordinator: compile failed.');
+ // TODO(dschuff): re-enable this test when the change with more detailed
+ // error reporting rolls in from NaCl.
+ //badLoadTest(
+ // tester,
+ // 'bad_pexe',
+ // 'pnacl_bad_pexe.nmf',
+ // 'application/x-pnacl',
+ // 'NaCl module load failed: PnaclCoordinator: compile failed.');
// 'nonexistent_pexe' loads a manifest, then tries to to load a nonexistent
// pexe and fails.
« no previous file with comments | « no previous file | ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698