Issue 23944005: [chromedriver] Fix race in navigation tracker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23944005: [chromedriver] Fix race in navigation tracker. (Closed)

Created:
7 years, 3 months ago by kkania

Modified:
7 years, 3 months ago

Reviewers:
chrisgao (Use stgao instead)

CC:
chromium-reviews, kkania, frankf

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[chromedriver] Fix race in navigation tracker. Somewhat reproducible via load google, clear cookies, load about:blank repeatedly. Before, when we attempted to get the URL of the page after a successful Page.navigate, we could end up setting the state = kLoading even though we received the frame stopped loading event during the evaluate command. Now, set the state to uknown first, and only force the state = kLoading if not set already. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221277

Patch Set 1 : . #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -1 line)			Patch
	M	chrome/test/chromedriver/chrome/navigation_tracker.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download
	M	chrome/test/chromedriver/chrome/navigation_tracker_unittest.cc	View		1 chunk	+17 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kkania@chromium.org/23944005/3001

7 years, 3 months ago (2013-09-04 19:35:13 UTC) #3

Message was sent while issue was closed.

Change committed as 221277

Expand Messages | Collapse Messages