Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1769)

Unified Diff: chrome/test/chromedriver/chrome/navigation_tracker_unittest.cc

Issue 23944005: [chromedriver] Fix race in navigation tracker. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/chromedriver/chrome/navigation_tracker.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/chrome/navigation_tracker_unittest.cc
diff --git a/chrome/test/chromedriver/chrome/navigation_tracker_unittest.cc b/chrome/test/chromedriver/chrome/navigation_tracker_unittest.cc
index 8b7f5f234b55ed5f65388fea8fc2d3d897bb460e..55f25e0924c7542ab461b3cd1367aae29b6fc94c 100644
--- a/chrome/test/chromedriver/chrome/navigation_tracker_unittest.cc
+++ b/chrome/test/chromedriver/chrome/navigation_tracker_unittest.cc
@@ -217,3 +217,20 @@ TEST(NavigationTracker, UnknownStateForcesStartReceivesStop) {
NavigationTracker tracker(&client);
ASSERT_NO_FATAL_FAILURE(AssertPendingState(&tracker, "f", false));
}
+
+TEST(NavigationTracker, OnSuccessfulNavigate) {
+ base::DictionaryValue params;
+ DeterminingLoadStateDevToolsClient client(
+ true, "Page.frameStoppedLoading", &params);
+ NavigationTracker tracker(&client, NavigationTracker::kNotLoading);
+ tracker.OnCommandSuccess(&client, "Page.navigate");
+ ASSERT_NO_FATAL_FAILURE(AssertPendingState(&tracker, "f", false));
+}
+
+TEST(NavigationTracker, OnSuccessfulNavigateStillWaiting) {
+ base::DictionaryValue params;
+ DeterminingLoadStateDevToolsClient client(true, std::string(), &params);
+ NavigationTracker tracker(&client, NavigationTracker::kNotLoading);
+ tracker.OnCommandSuccess(&client, "Page.navigate");
+ ASSERT_NO_FATAL_FAILURE(AssertPendingState(&tracker, "f", true));
+}
« no previous file with comments | « chrome/test/chromedriver/chrome/navigation_tracker.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698