[Android WebView] Remove some obsolete TODOs

[Android WebView] Remove some obsolete TODOs

There is no need to worry about not visible since process mode still
works.

There is no need to worry about processing calling invoke on the next
ViewRenderer because OnDetachFromWindow also processes pending GL
commands by necessity.

Losing global context will be handled in src/content since that's where
the global offscreen contexts live.

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223287

[boliu, 2013-09-04 20:26:34]

Another one that can wait until after m30 freeze.

[joth, 2013-09-04 20:30:03]

lgtm


On 4 September 2013 13:26, <boliu@chromium.org> wrote:

> A small code review. Reviewers: joth,
>
> Message:
> Another one that can wait until after m30 freeze.
>
> Description:
> [Android WebView] Remove some obsolete TODOs
>
> There is no need to worry about not visible since process mode still
> works.
>
> There is no need to worry about processing calling invoke on the next
> ViewRenderer because OnDetachFromWindow also processes pending GL
> commands by necessity.
>
> Losing global context will be handled in src/content since that's where
> the global offscreen contexts live.
>
> BUG=
>
> Please review this at
https://codereview.chromium.**org/23943006/<https://codereview.chromium.org/2...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files +0, -7:
>   M android_webview/browser/in_**process_view_renderer.cc
>
>
> Index: android_webview/browser/in_**process_view_renderer.cc
> diff --git a/android_webview/browser/in_**process_view_renderer.cc
> b/android_webview/browser/in_**process_view_renderer.cc
> index facb008ccc766eca0669780f2cf186**489fd3b5b2..**
> dd92c22a4d3f63d841cabc4f9a7819**e4c0a5ff0c 100644
> --- a/android_webview/browser/in_**process_view_renderer.cc
> +++ b/android_webview/browser/in_**process_view_renderer.cc
> @@ -250,18 +250,11 @@ InProcessViewRenderer::~**InProcessViewRenderer() {
>    DCHECK(web_contents_ == NULL);  // WebContentsGone should have been
> called.
>  }
>
> -
> -// TODO(boliu): Should also call this when we know for sure we are no
> longer,
> -// for example, when visible rect becomes 0.
>  void InProcessViewRenderer::**NoLongerExpectsDrawGL() {
>    GLViewRendererManager& mru = g_view_renderer_manager.Get();
>    if (manager_key_ != mru.NullKey()) {
>      mru.NoLongerExpectsDrawGL(**manager_key_);
>      manager_key_ = mru.NullKey();
> -
> -    // TODO(boliu): If this is the first one and there are GL pending,
> -    // requestDrawGL on next one.
> -    // TODO(boliu): If this is the last one, lose all global contexts.
>    }
>  }
>
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2013-09-15 07:06:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/boliu@chromium.org/23943006/1

[commit-bot: I haz the power, 2013-09-15 15:23:29]

Change committed as 223287