Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2034)

Unified Diff: android_webview/browser/in_process_view_renderer.cc

Issue 23943006: [Android WebView] Remove some obsolete TODOs (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/browser/in_process_view_renderer.cc
diff --git a/android_webview/browser/in_process_view_renderer.cc b/android_webview/browser/in_process_view_renderer.cc
index facb008ccc766eca0669780f2cf186489fd3b5b2..dd92c22a4d3f63d841cabc4f9a7819e4c0a5ff0c 100644
--- a/android_webview/browser/in_process_view_renderer.cc
+++ b/android_webview/browser/in_process_view_renderer.cc
@@ -250,18 +250,11 @@ InProcessViewRenderer::~InProcessViewRenderer() {
DCHECK(web_contents_ == NULL); // WebContentsGone should have been called.
}
-
-// TODO(boliu): Should also call this when we know for sure we are no longer,
-// for example, when visible rect becomes 0.
void InProcessViewRenderer::NoLongerExpectsDrawGL() {
GLViewRendererManager& mru = g_view_renderer_manager.Get();
if (manager_key_ != mru.NullKey()) {
mru.NoLongerExpectsDrawGL(manager_key_);
manager_key_ = mru.NullKey();
-
- // TODO(boliu): If this is the first one and there are GL pending,
- // requestDrawGL on next one.
- // TODO(boliu): If this is the last one, lose all global contexts.
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698