Fix label colors for dark native themes (incognito, shelf).

Fix label colors for dark native themes (incognito, shelf).

Regressed in f02568a216b975130849079183cc0f7173d6b832

BUG=653241
Committed: https://crrev.com/ec013bf782f54a4ef8f3897f390ca391c701bee2
Cr-Commit-Position: refs/heads/master@{#423556}

[Evan Stade, 2016-10-05 23:38:09]

estade@chromium.org changed reviewers:
+ tdanderson@chromium.org

[tdanderson, 2016-10-06 14:05:06]

https://chromiumcodereview.appspot.com/2394083002/diff/1/ui/native_theme/nati...
File ui/native_theme/native_theme_dark_aura.cc (right):

https://chromiumcodereview.appspot.com/2394083002/diff/1/ui/native_theme/nati...
ui/native_theme/native_theme_dark_aura.cc:34: // Window
Comparing this change to the CL where the regression was caused, I'm not 100%
certain why this fixes the label colors. Can you please clarify?

[Evan Stade, 2016-10-06 15:35:46]

https://chromiumcodereview.appspot.com/2394083002/diff/1/ui/native_theme/nati...
File ui/native_theme/native_theme_dark_aura.cc (right):

https://chromiumcodereview.appspot.com/2394083002/diff/1/ui/native_theme/nati...
ui/native_theme/native_theme_dark_aura.cc:34: // Window
On 2016/10/06 14:05:05, tdanderson wrote:
> Comparing this change to the CL where the regression was caused, I'm not 100%
> certain why this fixes the label colors. Can you please clarify?

we used to have a label background color for dark themes which was dark. This
color was being used for auto color readability. Then that got removed and we
started using dialog bg color in its place. That was returning red. Auto color
readability code decided that black on red was better than white on red.

[Evan Stade, 2016-10-06 15:36:00]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-06 15:36:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tdanderson, 2016-10-06 15:40:03]

On 2016/10/06 15:35:46, Evan Stade wrote:
>
https://chromiumcodereview.appspot.com/2394083002/diff/1/ui/native_theme/nati...
> File ui/native_theme/native_theme_dark_aura.cc (right):
> 
>
https://chromiumcodereview.appspot.com/2394083002/diff/1/ui/native_theme/nati...
> ui/native_theme/native_theme_dark_aura.cc:34: // Window
> On 2016/10/06 14:05:05, tdanderson wrote:
> > Comparing this change to the CL where the regression was caused, I'm not
100%
> > certain why this fixes the label colors. Can you please clarify?
> 
> we used to have a label background color for dark themes which was dark. This
> color was being used for auto color readability. Then that got removed and we
> started using dialog bg color in its place. That was returning red. Auto color
> readability code decided that black on red was better than white on red.

Thanks, lgtm

[Evan Stade, 2016-10-06 15:41:16]

The CQ bit was unchecked by estade@chromium.org

[Evan Stade, 2016-10-06 15:41:19]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2016-10-06 15:41:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 16:22:42]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-06 16:25:21]

Description was changed from

==========
Fix label colors for dark native themes (incognito, shelf).

Regressed in f02568a216b975130849079183cc0f7173d6b832

BUG=653241
==========

to

==========
Fix label colors for dark native themes (incognito, shelf).

Regressed in f02568a216b975130849079183cc0f7173d6b832

BUG=653241

Committed: https://crrev.com/ec013bf782f54a4ef8f3897f390ca391c701bee2
Cr-Commit-Position: refs/heads/master@{#423556}
==========

[commit-bot: I haz the power, 2016-10-06 16:25:22]

Patchset 1 (id:??) landed as
https://crrev.com/ec013bf782f54a4ef8f3897f390ca391c701bee2
Cr-Commit-Position: refs/heads/master@{#423556}