Fix label colors for dark native themes (incognito, shelf).

ui/native_theme/native_theme_dark_aura.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/native_theme/native_theme_dark_aura.h"
 
 #include "ui/gfx/color_palette.h"
 
 namespace ui {
 
@@ skipping 13 matching lines @@
   static const SkColor kTextfieldSelectionBackgroundFocused =
       SkColorSetA(gfx::kGoogleBlue700, 0xCC);
 
   static const SkColor kResultsTableNormalBackground =
       SkColorSetRGB(0x28, 0x28, 0x28);
   static const SkColor kResultsTableText = SK_ColorWHITE;
   static const SkColor kResultsTableDimmedText =
       SkColorSetA(kResultsTableText, 0x80);
 
   switch (color_id) {
+    // Window

[tdanderson, 2016/10/06 14:05:05]

Comparing this change to the CL where the regression was caused, I'm not 100%
certain why this fixes the label colors. Can you please clarify?

[Evan Stade, 2016/10/06 15:35:46]

we used to have a label background color for dark themes which was dark. This
color was being used for auto color readability. Then that got removed and we
started using dialog bg color in its place. That was returning red. Auto color
readability code decided that black on red was better than white on red.

+    case kColorId_WindowBackground:
+    case kColorId_DialogBackground:
+    case kColorId_BubbleBackground:
+      return SK_ColorBLACK;
+
     // Button
     case kColorId_ButtonEnabledColor:
       return kButtonEnabledColor;
     case kColorId_ProminentButtonColor:
       return gfx::kGoogleBlue300;
 
     // Label
     case kColorId_LabelEnabledColor:
       return kPrimaryTextColor;
 
@@ skipping 40 matching lines @@
     case kColorId_TextOnProminentButtonColor:
     case kColorId_ButtonPressedShade:
     case kColorId_ResultsTableHoveredBackground:
     case kColorId_ResultsTableSelectedBackground:
     case kColorId_ResultsTableNormalUrl:
     case kColorId_ResultsTableHoveredUrl:
     case kColorId_ResultsTableSelectedUrl:
       return NativeThemeAura::GetSystemColor(color_id);
 
     // Any other color is not defined and shouldn't be used in a dark theme.
-    case kColorId_WindowBackground:
-    case kColorId_DialogBackground:
-    case kColorId_BubbleBackground:
     case kColorId_UnfocusedBorderColor:
     case kColorId_ButtonDisabledColor:
     case kColorId_ButtonHoverColor:
     case kColorId_BlueButtonEnabledColor:
     case kColorId_BlueButtonDisabledColor:
     case kColorId_BlueButtonPressedColor:
     case kColorId_BlueButtonHoverColor:
     case kColorId_BlueButtonShadowColor:
     case kColorId_EnabledMenuItemForegroundColor:
     case kColorId_DisabledMenuItemForegroundColor:
@@ skipping 39 matching lines @@
 
   NOTREACHED();
   return gfx::kPlaceholderColor;
 }
 
 NativeThemeDarkAura::NativeThemeDarkAura() {}
 
 NativeThemeDarkAura::~NativeThemeDarkAura() {}
 
 }  // namespace ui