telemetry: Fixed bug in trace_event_importer.

telemetry: Fixed bug in trace_event_importer.

R=tonyg@chromium.org
BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221830

[tonyg, 2013-09-06 18:50:17]

https://codereview.chromium.org/23936003/diff/1/tools/telemetry/telemetry/cor...
File tools/telemetry/telemetry/core/timeline/trace_event_importer.py (right):

https://codereview.chromium.org/23936003/diff/1/tools/telemetry/telemetry/cor...
tools/telemetry/telemetry/core/timeline/trace_event_importer.py:278:
str(event_id) + ' was alrady open.')
These should really be:

'At %d, a slice...' % event['ts']

[ernstm, 2013-09-06 19:43:33]

https://codereview.chromium.org/23936003/diff/1/tools/telemetry/telemetry/cor...
File tools/telemetry/telemetry/core/timeline/trace_event_importer.py (right):

https://codereview.chromium.org/23936003/diff/1/tools/telemetry/telemetry/cor...
tools/telemetry/telemetry/core/timeline/trace_event_importer.py:278:
str(event_id) + ' was alrady open.')
On 2013/09/06 18:50:17, tonyg wrote:
> These should really be:
> 
> 'At %d, a slice...' % event['ts']

Done. Turns out that event_id is not an int. So no conversion needed there.

[tonyg, 2013-09-06 19:45:53]

https://codereview.chromium.org/23936003/diff/6001/tools/telemetry/telemetry/...
File tools/telemetry/telemetry/core/timeline/trace_event_importer.py (right):

https://codereview.chromium.org/23936003/diff/6001/tools/telemetry/telemetry/...
tools/telemetry/telemetry/core/timeline/trace_event_importer.py:278: event_id +
' was alrady open.')
Sorry, I wasn't explicit in my previous comment. This would be more readable as:

'At %d, a slice of the same id %s was already open.' % (event['ts'], event_id)

[ernstm, 2013-09-06 21:00:02]

https://codereview.chromium.org/23936003/diff/6001/tools/telemetry/telemetry/...
File tools/telemetry/telemetry/core/timeline/trace_event_importer.py (right):

https://codereview.chromium.org/23936003/diff/6001/tools/telemetry/telemetry/...
tools/telemetry/telemetry/core/timeline/trace_event_importer.py:278: event_id +
' was alrady open.')
On 2013/09/06 19:45:53, tonyg wrote:
> Sorry, I wasn't explicit in my previous comment. This would be more readable
as:
> 
> 'At %d, a slice of the same id %s was already open.' % (event['ts'], event_id)

Done.

[tonyg, 2013-09-06 21:01:18]

lgtm

Thanks for bearing with me on the nits

[commit-bot: I haz the power, 2013-09-06 21:02:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ernstm@chromium.org/23936003/11001

[commit-bot: I haz the power, 2013-09-06 21:09:19]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_cl...

[commit-bot: I haz the power, 2013-09-06 22:15:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ernstm@chromium.org/23936003/11001

[commit-bot: I haz the power, 2013-09-07 00:19:40]

Change committed as 221830